Remove uses of JS classes in OCaml, Part 1 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitschabaude
changed the title
Trivo25
approved these changes
Jun 12, 2023
| @@ -22,7 +22,7 @@ let _console_dir s : unit = | |||
| let raise_error s = | |||
| Js.Js_error.(raise_ @@ of_error (new%js Js.error_constr (Js.string s))) | |||
|
|
|||
| let raise_errorf fmt = Core_kernel.ksprintf raise_error fmt | |||
| let _raise_errorf fmt = Core_kernel.ksprintf raise_error fmt | |||
There was a problem hiding this comment.
if these arent used anymore, should we just remove them? I noticed _console_logalso isnt used anymore
There was a problem hiding this comment.
well, for _console_log, I always use that if I need to debug something, and deleting it would cost me time to reimplement it. Not sure about _raise_errorf, yeah maybe we can delete that
There was a problem hiding this comment.
well, for _console_log, I always use that if I need to debug something
Ah okay, that makes sense!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove most uses of JS classes from snarkyjs-ocaml, except the field and bool classes themselves