Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of JS classes in OCaml, Part 1 #956

Merged
merged 19 commits into from
Jun 12, 2023
Merged

Conversation

mitschabaude
Copy link
Member

@mitschabaude mitschabaude commented Jun 5, 2023

bindings: o1-labs/o1js-bindings#34

follow up PR to #902, #932, #935

this works towards removing the ocaml Field and Bool classes, by moving to lower level field representations in ALL APIs exposed from ocaml, except Field and Bool themselves. For example, this changes the Poseidon and Pickles APIs, and various helpers. TS to ml conversion logic is moved to TS, to keep the ml side as light as possible.

We also continue the work of #935 of moving helper functions on Ledger to a Test module and relegating them to consistency tests (while using TS impls in snarkyjs)

Note: this PR doesn't yet remove old Field and Bool to keep it independent from the Bool refactor #936

@mitschabaude mitschabaude changed the base branch from main to refactor/scalar June 7, 2023 13:19
Base automatically changed from refactor/scalar to main June 8, 2023 14:35
@mitschabaude mitschabaude marked this pull request as ready for review June 8, 2023 14:45
@mitschabaude mitschabaude changed the title Remove uses of JS classes in OCaml Remove uses of JS classes in OCaml, Part 1 Jun 8, 2023
@mitschabaude mitschabaude merged commit ffad51c into main Jun 12, 2023
9 checks passed
@mitschabaude mitschabaude deleted the refactor/cleanup branch June 12, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants