-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove uses of JS classes in OCaml, Part 1 #956
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trivo25
approved these changes
Jun 12, 2023
This was referenced Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bindings: o1-labs/o1js-bindings#34
follow up PR to #902, #932, #935
this works towards removing the ocaml Field and Bool classes, by moving to lower level field representations in ALL APIs exposed from ocaml, except Field and Bool themselves. For example, this changes the Poseidon and Pickles APIs, and various helpers. TS to ml conversion logic is moved to TS, to keep the ml side as light as possible.
We also continue the work of #935 of moving helper functions on
Ledger
to aTest
module and relegating them to consistency tests (while using TS impls in snarkyjs)Note: this PR doesn't yet remove old
Field
andBool
to keep it independent from theBool
refactor #936