-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make proving/verifying work in SnarkyJS with kimchi #49
Comments
Matt fixed the proving bug, and proving works for the low-level However, this isn't quite done, because recursive pickles proofs don't work yet (which are the ones we need for snapps). The issue is that they get returned as a |
Pushed a branch which seems to solve the problem described above: https://github.com/MinaProtocol/mina/tree/feature/snarkyjs-pickles-proof However, a new issue turned up - a missing implementation of |
Set up this PR to fix the async prover issue: MinaProtocol/mina#10454 |
Multiple Wasm / bindings issues are fixed, and the proof seems to work - there's only an issue with asyncness left, where the proof is computed, but the promise that should hold it resolves early with a value of |
Proving works 🎉 I'll devote another morning to see if I can get pickles verifying to work in JS as well, because that would be a nice sanity check. (Verifying already works for non-recursive proofs, so we shouldn't be too far off) |
Verify works as well now 🎉 The only remaining TODO is to fix the regressions that come up when merging develop in the branch where it works (MinaProtocol/mina#10267) |
As snarkyjs is being merged in a version where everything works and is tested in CI, this can be closed :) |
Blocking SnarkyJS CI tests (berkeley)
No description provided.
The text was updated successfully, but these errors were encountered: