Refactor Nullifier methods to use safer MerkleMapWitness operations #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinMinkov
force-pushed
the
feat/fix-nullifier
branch
from
e913ae7
to
a7a7e47
Compare
MartinMinkov
changed the title
computeRootAndKeyV2computeRootAndKeyV2
mitschabaude
reviewed
Jul 3, 2024
|
So I'm saying, I don't see why we have to add another version of the class in this case |
MartinMinkov
force-pushed
the
feat/fix-nullifier
branch
from
44c3664
to
1d3c50b
Compare
MartinMinkov
changed the title
computeRootAndKeyV2
Yeah, that was my mistake. Changed the PR to this approach instead! |
mitschabaude
approved these changes
Jul 3, 2024
…thods in favor of V2 versions feat(nullifier): add isUnusedV2, assertUnusedV2, and setUsedV2 methods that use the safer MerkleMapWitness.computeRootAndKeyV2 docs(nullifier): add deprecation notices to isUnused, assertUnused, and setUsed methods, and update examples to use V2 versions The original methods used the deprecated MerkleMapWitness.computeRootAndKey which may be vulnerable to hash collisions in key indices. The new V2 methods utilize the safer MerkleMapWitness.computeRootAndKeyV2 to mitigate this issue and improve the security of the nullifier operations.
The nullifier methods `assertUnused` and `setUsed` have been updated to their V2 counterparts `assertUnusedV2` and `setUsedV2` respectively. This change is made to use the latest versions of these methods which likely include performance improvements, bug fixes, or additional functionality compared to the previous versions.
The new methods `isUnusedV2()`, `assertUnusedV2()`, and `setUsedV2()` have been introduced to provide improved functionality for nullifier operations. BREAKING CHANGE: deprecate Nullifier.isUnused(), Nullifier.assertUnused(), and Nullifier.setUsed() methods The existing `Nullifier.isUnused()`, `Nullifier.assertUnused()`, and `Nullifier.setUsed()` methods have been deprecated in favor of the new V2 methods. These deprecated methods will be removed in a future release. Please update your code to use the new V2 methods instead.
MartinMinkov
force-pushed
the
feat/fix-nullifier
branch
from
6f532d1
to
fb1e4fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.