Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Reducer, token, MerkleTree off Experimental #555

Merged
merged 7 commits into from
Nov 15, 2022
Merged

Move Reducer, token, MerkleTree off Experimental #555

merged 7 commits into from
Nov 15, 2022

Conversation

mitschabaude
Copy link
Member

@mitschabaude mitschabaude commented Nov 15, 2022 •
edited
Loading

Trivo25
Trivo25 reviewed Nov 15, 2022
View reviewed changes
CHANGELOG.md

### Fixed

- Uint comparisons and division fixed inside the prover https://github.com/o1-labs/snarkyjs/pull/503
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UInt

Trivo25
Trivo25 approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@Trivo25 Trivo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe src/lib/merkle_tree.test.ts and /src/examples/zkapps/merkle_tree/merkle_zkapp.ts needs changing as well

but lgtm!

@mitschabaude mitschabaude merged commit d68e574 into main Nov 15, 2022
@mitschabaude mitschabaude deleted the feature/less-experimental branch November 15, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trivo25 Trivo25 Trivo25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move MerkleTree, Reducer and token APIs off Experimental
2 participants
@mitschabaude @Trivo25