Fix: fetch missing access permission #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitschabaude
force-pushed
the
fix/fetch-access-permission
branch
from
fe7eec3
to
50fdd5c
Compare
Trivo25
approved these changes
Apr 12, 2023
CHANGELOG.md
Outdated
| ### Fixed | ||
|
|
||
| - Fix fetching the `access` permission on accounts https://github.com/o1-labs/snarkyjs/pull/851 | ||
| - Fixes to `fetchActions` https://github.com/o1-labs/snarkyjs/pull/844 https://github.com/o1-labs/snarkyjs/pull/854 [@Comdex](https://github.com/Comdex) |
There was a problem hiding this comment.
the to here sounds wrong, not sure if that makes sense here 🤔
There was a problem hiding this comment.
I meant multiple different fixes to the same function, but yeah I guess that's not clearly formulated
nicc
added
product-eng
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
accesspermission which was accidentally not fetched. The previous behaviour was thatpermissions.accesswas undefined and got coerced to aNonepermission