Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix silent deploy fail with no verification key #885

Merged
merged 3 commits into from
May 2, 2023
Merged

Fix silent deploy fail with no verification key #885

merged 3 commits into from
May 2, 2023

Conversation

mitschabaude
Copy link
Member

@mitschabaude mitschabaude commented May 2, 2023 •
edited
Loading

Fixes the behaviour of deploy() when no verification key is found (and we have proofsEnabled: true)

OLD: deploy() silently didn't update the verification key, but still updates some permissions to "proof", breaking the zkApp

NEW: deploy() throws an error to remind you to compile() before calling deploy()

@mitschabaude mitschabaude merged commit d5f9ba7 into main May 2, 2023
@mitschabaude mitschabaude deleted the fix/no-silent-deploy-fail branch May 2, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trivo25 Trivo25 Trivo25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitschabaude @Trivo25