Move Scalar to JS #935
Merged
Move Scalar to JS #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trivo25
reviewed
Jun 8, 2023
Trivo25
approved these changes
Jun 8, 2023
| import { Field as InternalField } from './field.js'; | ||
| import { Group as InternalGroup } from './group.js'; | ||
| import { Scalar as ScalarBigint } from '../provable/curve-bigint.js'; | ||
| import { mod } from '../bindings/crypto/finite_field.js'; | ||
| import { Scalar } from './scalar.js'; |
There was a problem hiding this comment.
Do we want to add the function constructor for the Scalar as well? I am a bit unsure - while it would be uniform, Scalar is also not really a primitive like Field or Bool, especially since you cant prove operations like addition 🤔
There was a problem hiding this comment.
Good point. I think the need is not pressing and requires refactoring the current constructor, so would save it for a future PR
bkase
approved these changes
Jun 8, 2023
| return Scalar.from(z); | ||
| } | ||
|
|
||
| // TODO don't leak 'shifting' to the user and remove these methods |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #925
bindings: o1-labs/o1js-bindings#30
This PR continues the work of #902 by moving the
Scalarclass from OCaml to JS. The OCaml class is removed entirely. Apart from minor API changes like introduction ofScalar.toConstant()(useful for tests), this keeps the same API intact. The internal representation ofScalarstays the same as before because theGroupclass relies on the structure and the PR to move that is in flight.Some other things we also did, which stick to the theme of cleaning up the OCaml side:
PrivateKey.to/fromBase58to be the pure TS implementationLedgermodule to theTestmodule, because they are only used for tests nowsignFeePayermethod from the global exports and a couple of exposed functions that it depended on