Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASV Samples That Require Baked ShaderVariantAssets Must Check The Registry Key "O3DE/Atom/Shaders/BuildVariants" #324

Open
galibzon opened this issue Jan 20, 2022 · 2 comments
Labels
good first issue Good for newcomers priority/minor Lowest priority. Work that may be scheduled sig/graphics-audio

Comments

@galibzon
Copy link
Contributor

For the sake of iteration speed, sometimes engineers set the registry key "O3DE/Atom/Shaders/BuildVariants" to "False" and forget about it.
One day they run ASV Samples like "RHI/IndirectRendering" and the samples fail to run properly because the sample is waiting for some particular ShaderVariantAssets to be ready, but the OnShaderVariantReinitialized() notification never arrives. The engineer can struggle for hours because they forgot to set "O3DE/Atom/Shaders/BuildVariants" back to "True".

Solution:
All ASV Samples that require Baked ShaderVariantAssets must check if the registry key "O3DE/Atom/Shaders/BuildVariants" is enabled. If it is not enabled, then an explicit message should be presented to the user.

By default, the file: "\GIT\o3de\Gems\Atom\Asset\Shader\Registry\atom_shaders.setreg" has such key set to "True".

@galibzon
Copy link
Contributor Author

@Adi-Amazon

@galibzon galibzon changed the title ASV Samples That Require Baked ShaderVariantAssets Must Check If The Registry Key "O3DE/Atom/Shaders/BuildVariants" ASV Samples That Require Baked ShaderVariantAssets Must Check The Registry Key "O3DE/Atom/Shaders/BuildVariants" Jan 20, 2022
@superkitcath superkitcath added needs-triage Indicates an issue or PR needs triage good first issue Good for newcomers priority/major Major priority. Work that should be handled after all blocking and critical work is done. priority/minor Lowest priority. Work that may be scheduled and removed needs-triage Indicates an issue or PR needs triage priority/major Major priority. Work that should be handled after all blocking and critical work is done. labels Mar 1, 2022
@moudgils
Copy link
Contributor

moudgils commented Apr 7, 2023

@galibzon close this if not applicable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers priority/minor Lowest priority. Work that may be scheduled sig/graphics-audio
Projects
None yet
Development

No branches or pull requests

3 participants