-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix template preview images; add obj #586
fix template preview images; add obj #586
Conversation
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Can you also update the display name for the Manipulation Robot Template? Maybe call it "ROS2 Robotic Manipulation Template" |
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
I set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good
* add obj format to importer registry * update template preview images * fix Ros2RoboticManipulationTemlate template.json --------- Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
* add obj format to importer registry * update template preview images * fix Ros2RoboticManipulationTemlate template.json --------- Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
* add obj format to importer registry * update template preview images * fix Ros2RoboticManipulationTemlate template.json --------- Signed-off-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com>
…#614) * fix template preview images; add obj (#586) * add obj format to importer registry * update template preview images * fix Ros2RoboticManipulationTemlate template.json --------- Signed-off-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com> * Updated readmes to include new features, fix typos etc. (#580) * Updated readmes to include new features, fix typos etc. * Update Gems/ROS2/README.md --------- Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Co-authored-by: Paweł Budziszewski <pawel.budziszewski@robotec.ai> * Broadcast transforms en masse (#584) Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> * Change kinematic update to pre-simulation (#583) Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> * Change spawnning of robots during import (#598) * Change spawnning of robots during import --------- Signed-off-by: Artur Kamieniecki <130671280+arturkamieniecki@users.noreply.github.com> * Change reflect in spawn points (#602) Signed-off-by: Artur Kamieniecki <130671280+arturkamieniecki@users.noreply.github.com> * fix lidars in ROSBot prefabs (#588) Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> --------- Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Signed-off-by: Artur Kamieniecki <130671280+arturkamieniecki@users.noreply.github.com> Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> Co-authored-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Co-authored-by: Artur Kamieniecki <130671280+arturkamieniecki@users.noreply.github.com>
* add obj format to importer registry * update template preview images * fix Ros2RoboticManipulationTemlate template.json --------- Signed-off-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com>
* add obj format to importer registry * update template preview images * fix Ros2RoboticManipulationTemlate template.json --------- Signed-off-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com> Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
* add obj format to importer registry * update template preview images * fix Ros2RoboticManipulationTemlate template.json --------- Signed-off-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com> Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
…#614) * fix template preview images; add obj (#586) * add obj format to importer registry * update template preview images * fix Ros2RoboticManipulationTemlate template.json --------- Signed-off-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com> * Updated readmes to include new features, fix typos etc. (#580) * Updated readmes to include new features, fix typos etc. * Update Gems/ROS2/README.md --------- Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Co-authored-by: Paweł Budziszewski <pawel.budziszewski@robotec.ai> * Broadcast transforms en masse (#584) Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> * Change kinematic update to pre-simulation (#583) Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> * Change spawnning of robots during import (#598) * Change spawnning of robots during import --------- Signed-off-by: Artur Kamieniecki <130671280+arturkamieniecki@users.noreply.github.com> * Change reflect in spawn points (#602) Signed-off-by: Artur Kamieniecki <130671280+arturkamieniecki@users.noreply.github.com> * fix lidars in ROSBot prefabs (#588) Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> --------- Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Signed-off-by: Artur Kamieniecki <130671280+arturkamieniecki@users.noreply.github.com> Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> Co-authored-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Co-authored-by: Artur Kamieniecki <130671280+arturkamieniecki@users.noreply.github.com>
* add obj format to importer registry * update template preview images * fix Ros2RoboticManipulationTemlate template.json --------- Signed-off-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com> Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Closes #556
This PR fixes two problems with templates:
.obj
format to registry settings ensuring, that.obj
files can be imported when a project is generated based on the template following the default behavior of o3deAll aspect ratio seems fixed now: