fix lidars in ROSBot prefabs #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
adamdbrw
approved these changes
Nov 6, 2023
pawelbudziszewski
approved these changes
Nov 10, 2023
adamdbrw
pushed a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Nov 20, 2023
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
michalpelka
pushed a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Nov 22, 2023
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
adamdbrw
added a commit
that referenced
this pull request
Nov 24, 2023
…#614) * fix template preview images; add obj (#586) * add obj format to importer registry * update template preview images * fix Ros2RoboticManipulationTemlate template.json --------- Signed-off-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com> * Updated readmes to include new features, fix typos etc. (#580) * Updated readmes to include new features, fix typos etc. * Update Gems/ROS2/README.md --------- Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Co-authored-by: Paweł Budziszewski <pawel.budziszewski@robotec.ai> * Broadcast transforms en masse (#584) Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> * Change kinematic update to pre-simulation (#583) Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> * Change spawnning of robots during import (#598) * Change spawnning of robots during import --------- Signed-off-by: Artur Kamieniecki <130671280+arturkamieniecki@users.noreply.github.com> * Change reflect in spawn points (#602) Signed-off-by: Artur Kamieniecki <130671280+arturkamieniecki@users.noreply.github.com> * fix lidars in ROSBot prefabs (#588) Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> --------- Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Signed-off-by: Artur Kamieniecki <130671280+arturkamieniecki@users.noreply.github.com> Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> Co-authored-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Co-authored-by: Artur Kamieniecki <130671280+arturkamieniecki@users.noreply.github.com>
adamdbrw
pushed a commit
that referenced
this pull request
Nov 24, 2023
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
adamdbrw
pushed a commit
that referenced
this pull request
Nov 24, 2023
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
michalpelka
pushed a commit
that referenced
this pull request
Nov 28, 2023
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
michalpelka
added a commit
that referenced
this pull request
Dec 6, 2023
…#614) * fix template preview images; add obj (#586) * add obj format to importer registry * update template preview images * fix Ros2RoboticManipulationTemlate template.json --------- Signed-off-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com> * Updated readmes to include new features, fix typos etc. (#580) * Updated readmes to include new features, fix typos etc. * Update Gems/ROS2/README.md --------- Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Co-authored-by: Paweł Budziszewski <pawel.budziszewski@robotec.ai> * Broadcast transforms en masse (#584) Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> * Change kinematic update to pre-simulation (#583) Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> * Change spawnning of robots during import (#598) * Change spawnning of robots during import --------- Signed-off-by: Artur Kamieniecki <130671280+arturkamieniecki@users.noreply.github.com> * Change reflect in spawn points (#602) Signed-off-by: Artur Kamieniecki <130671280+arturkamieniecki@users.noreply.github.com> * fix lidars in ROSBot prefabs (#588) Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> --------- Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Signed-off-by: Artur Kamieniecki <130671280+arturkamieniecki@users.noreply.github.com> Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> Co-authored-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Co-authored-by: Artur Kamieniecki <130671280+arturkamieniecki@users.noreply.github.com>
michalpelka
pushed a commit
that referenced
this pull request
Dec 6, 2023
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai> Signed-off-by: Adam Dąbrowski <adam.dabrowski@robotec.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lidars in
RosRobotSamplegem were set to custom instead of the defined ones. Some parameters were incorrect.Before:
After:
