handle dynamic container elements #17411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Montgomery <alexmont@amazon.com>
alexmontAmazon
requested review from
forkercat,
AMZN-alexpete,
Ulrick28 and
AMZN-daimini
forkercat
approved these changes
Jan 22, 2024
alexmontAmazon
added a commit
to alexmontAmazon/o3de
that referenced
this pull request
Feb 22, 2024
Signed-off-by: Alex Montgomery <alexmont@amazon.com>
alexmontAmazon
added a commit
that referenced
this pull request
Feb 23, 2024
* handle dynamic container elements (#17411) Signed-off-by: Alex Montgomery <alexmont@amazon.com> * re-enable recycling, esp for prefab override labels (#17343) * re-enable recycling, esp for prefab override labels Signed-off-by: Alex Montgomery <alexmont@amazon.com> * addressed PR feedback Signed-off-by: Alex Montgomery <alexmont@amazon.com> * forcing immediate deletion to satisfy tests Signed-off-by: Alex Montgomery <alexmont@amazon.com> * try Qt's shared pointers instead Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com> * fix element add for containers with DynamicElementType (#17441) * handle dynamic container elements Signed-off-by: Alex Montgomery <alexmont@amazon.com> * not quite working dynamic add Signed-off-by: Alex Montgomery <alexmont@amazon.com> * container dynamic add works Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com> * Handle ClassElement::FLG_POINTER in DPE-based Inspector (#17457) * handle dynamic container elements Signed-off-by: Alex Montgomery <alexmont@amazon.com> * not quite working dynamic add Signed-off-by: Alex Montgomery <alexmont@amazon.com> * container dynamic add works Signed-off-by: Alex Montgomery <alexmont@amazon.com> * implemented baseclass container element addition Signed-off-by: Alex Montgomery <alexmont@amazon.com> * Update Code/Framework/AzFramework/AzFramework/DocumentPropertyEditor/ReflectionAdapter.cpp Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com> Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com> Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com> * Speed up DPE's color picker handling by 2-3x and disallow redundant updates (#17493) * queue refresh in singleshot to keep it from happening more than once a loop Signed-off-by: Alex Montgomery <alexmont@amazon.com> * doubled the color picker performance Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com> * added recycling capability to several common handlers (#17512) Signed-off-by: Alex Montgomery <alexmont@amazon.com> * fix unused assert Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com> Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How was this PR tested?
locally in the Editor project