-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up DPE's color picker handling by 2-3x and disallow redundant updates #17493
Speed up DPE's color picker handling by 2-3x and disallow redundant updates #17493
Conversation
loop Signed-off-by: Alex Montgomery <alexmont@amazon.com>
Signed-off-by: Alex Montgomery <alexmont@amazon.com>
…ateOptimizations Signed-off-by: Alex Montgomery <alexmont@amazon.com>
Please test this thoroughly with DPE disabled or material editor, material instance editor, and other RPE and non-DPE use cases. With material editor and material instance editor, please make sure that colors are applied while continuously dragging color or other sliders in the color picker. |
I'll happily test in the material instance editor, but yeah, I did test in the RPE Inspector and it's still applying the colors continuously on drag and performing better than ever |
@gadams3 |
…pdates (o3de#17493) * queue refresh in singleshot to keep it from happening more than once a loop Signed-off-by: Alex Montgomery <alexmont@amazon.com> * doubled the color picker performance Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com>
* handle dynamic container elements (#17411) Signed-off-by: Alex Montgomery <alexmont@amazon.com> * re-enable recycling, esp for prefab override labels (#17343) * re-enable recycling, esp for prefab override labels Signed-off-by: Alex Montgomery <alexmont@amazon.com> * addressed PR feedback Signed-off-by: Alex Montgomery <alexmont@amazon.com> * forcing immediate deletion to satisfy tests Signed-off-by: Alex Montgomery <alexmont@amazon.com> * try Qt's shared pointers instead Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com> * fix element add for containers with DynamicElementType (#17441) * handle dynamic container elements Signed-off-by: Alex Montgomery <alexmont@amazon.com> * not quite working dynamic add Signed-off-by: Alex Montgomery <alexmont@amazon.com> * container dynamic add works Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com> * Handle ClassElement::FLG_POINTER in DPE-based Inspector (#17457) * handle dynamic container elements Signed-off-by: Alex Montgomery <alexmont@amazon.com> * not quite working dynamic add Signed-off-by: Alex Montgomery <alexmont@amazon.com> * container dynamic add works Signed-off-by: Alex Montgomery <alexmont@amazon.com> * implemented baseclass container element addition Signed-off-by: Alex Montgomery <alexmont@amazon.com> * Update Code/Framework/AzFramework/AzFramework/DocumentPropertyEditor/ReflectionAdapter.cpp Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com> Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com> Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com> * Speed up DPE's color picker handling by 2-3x and disallow redundant updates (#17493) * queue refresh in singleshot to keep it from happening more than once a loop Signed-off-by: Alex Montgomery <alexmont@amazon.com> * doubled the color picker performance Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com> * added recycling capability to several common handlers (#17512) Signed-off-by: Alex Montgomery <alexmont@amazon.com> * fix unused assert Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com> Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
What does this PR do?
How was this PR tested?
Please describe any testing performed.