-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle ClassElement::FLG_POINTER in DPE-based Inspector #17457
Handle ClassElement::FLG_POINTER in DPE-based Inspector #17457
Conversation
Signed-off-by: Alex Montgomery <alexmont@amazon.com>
…amicFix Signed-off-by: Alex Montgomery <alexmont@amazon.com>
…amicFix Signed-off-by: Alex Montgomery <alexmont@amazon.com>
Signed-off-by: Alex Montgomery <alexmont@amazon.com>
Signed-off-by: Alex Montgomery <alexmont@amazon.com>
…amicFix Signed-off-by: Alex Montgomery <alexmont@amazon.com>
Signed-off-by: Alex Montgomery <alexmont@amazon.com>
Code/Framework/AzFramework/AzFramework/DocumentPropertyEditor/ReflectionAdapter.cpp
Outdated
Show resolved
Hide resolved
@@ -1762,7 +1763,62 @@ namespace AzToolsFramework | |||
} | |||
}; | |||
|
|||
message.Match(AZ::DocumentPropertyEditor::Nodes::Adapter::QueryKey, showKeyQueryDialog); | |||
auto showQuerySubclassDialog = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there any common scenarios where this dialog is needed? do any of our components do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not yet exactly, but I agree that it's a good idea to factor this out. For now, I want to get this issue fixed ASAP, so I going to merge this as-is, and work to factor out a Dialog in a following PR.
…ReflectionAdapter.cpp Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com> Signed-off-by: Alex Montgomery <alexmont@amazon.com>
* handle dynamic container elements Signed-off-by: Alex Montgomery <alexmont@amazon.com> * not quite working dynamic add Signed-off-by: Alex Montgomery <alexmont@amazon.com> * container dynamic add works Signed-off-by: Alex Montgomery <alexmont@amazon.com> * implemented baseclass container element addition Signed-off-by: Alex Montgomery <alexmont@amazon.com> * Update Code/Framework/AzFramework/AzFramework/DocumentPropertyEditor/ReflectionAdapter.cpp Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com> Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com> Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
* handle dynamic container elements (#17411) Signed-off-by: Alex Montgomery <alexmont@amazon.com> * re-enable recycling, esp for prefab override labels (#17343) * re-enable recycling, esp for prefab override labels Signed-off-by: Alex Montgomery <alexmont@amazon.com> * addressed PR feedback Signed-off-by: Alex Montgomery <alexmont@amazon.com> * forcing immediate deletion to satisfy tests Signed-off-by: Alex Montgomery <alexmont@amazon.com> * try Qt's shared pointers instead Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com> * fix element add for containers with DynamicElementType (#17441) * handle dynamic container elements Signed-off-by: Alex Montgomery <alexmont@amazon.com> * not quite working dynamic add Signed-off-by: Alex Montgomery <alexmont@amazon.com> * container dynamic add works Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com> * Handle ClassElement::FLG_POINTER in DPE-based Inspector (#17457) * handle dynamic container elements Signed-off-by: Alex Montgomery <alexmont@amazon.com> * not quite working dynamic add Signed-off-by: Alex Montgomery <alexmont@amazon.com> * container dynamic add works Signed-off-by: Alex Montgomery <alexmont@amazon.com> * implemented baseclass container element addition Signed-off-by: Alex Montgomery <alexmont@amazon.com> * Update Code/Framework/AzFramework/AzFramework/DocumentPropertyEditor/ReflectionAdapter.cpp Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com> Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com> Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com> * Speed up DPE's color picker handling by 2-3x and disallow redundant updates (#17493) * queue refresh in singleshot to keep it from happening more than once a loop Signed-off-by: Alex Montgomery <alexmont@amazon.com> * doubled the color picker performance Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com> * added recycling capability to several common handlers (#17512) Signed-off-by: Alex Montgomery <alexmont@amazon.com> * fix unused assert Signed-off-by: Alex Montgomery <alexmont@amazon.com> --------- Signed-off-by: Alex Montgomery <alexmont@amazon.com> Co-authored-by: Alex Peterson <26804013+AMZN-alexpete@users.noreply.github.com>
What does this PR do?
How was this PR tested?
locally in the Editor