Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIG Reviewer Nomination #15

Closed
SWMasterson opened this issue Nov 5, 2021 · 4 comments
Closed

SIG Reviewer Nomination #15

SWMasterson opened this issue Nov 5, 2021 · 4 comments
Assignees

Comments

@SWMasterson
Copy link

Nomination Guidelines

Reviewer Nomination Requirements

  • 6+ contributions successfully submitted to O3DE
  • 100+ lines of code changed across all contributions submitted to O3DE
  • 2+ O3DE Reviewers or Maintainers that support promotion from Contributor to Reviewer
  • Requirements to retain the Reviewer role: 4+ Pull Requests reviewed per month

ReviewerNomination


I would like to nominate: SWMasterson, to become a Reviewer on behalf of sig-testing. I verify that they have fulfilled the prerequisites for this role.

Reviewers & Maintainers that support this nomination should comment in this issue.

@smurly
Copy link
Contributor

smurly commented Nov 5, 2021

I support Sean for Reviewer status. He's already made 3 automation pull requests 2 of which are merged. His code reviewing has been thorough.

@jromnoa
Copy link

jromnoa commented Nov 5, 2021

I support this as well, having Sean as a reviewer would be a huge benefit to our team.

@NeilGitGud
Copy link

NeilGitGud commented Nov 5, 2021

I support Sean for reviewer status as well. He has provided valuable and actionable feedback on several of my recent PRs, and has earned his reviewer status.

@AMZN-Dk AMZN-Dk transferred this issue from o3de/sig-content Nov 5, 2021
@Kadino
Copy link
Collaborator

Kadino commented Dec 17, 2021

@SWMasterson do you now have the proper permissions? @AMZN-Dk is following up in discord in #sig-docs-community about next steps.

@Kadino Kadino self-assigned this Jan 7, 2022
@AMZN-Dk AMZN-Dk closed this as completed Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants