Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong metadata pulled from source (wrong match) #33

Closed
Typhonragewind opened this issue Nov 8, 2022 · 1 comment · Fixed by #30
Closed

Wrong metadata pulled from source (wrong match) #33

Typhonragewind opened this issue Nov 8, 2022 · 1 comment · Fixed by #30
Labels
bug Something isn't working

Comments

@Typhonragewind
Copy link

Describe the bug

I don't know if this is a problem originating from mangal or some glitch in your code, but i'll post it here.
It doesn't happen with all mangas, just with some that i have yet to see the correlation with.

So what happens is that when you search a source (this is not source specific) for a certain manga, say The Gamer (https://mangadex.org/title/e499ff53-68d3-4c1a-8dbf-3cea42fca501/the-gamer) then UI then shows a list of Mangas with that name included, but when you choose it, the metadata it downloads pertains to another manga of similar name (The Gourmet Gamer - https://mangadex.org/title/da0f55cd-4878-4f65-b56a-25882b6c8376/the-gourmet-gamer). Then, if you click to add it to the library, the wrogn manga actually gets downloaded and not the correct one.

However, some of these get corrected when enabling anilist integration (even without account), but not all
If I use mangal CLI to search for the manga directly, it arrives at the correct one.

I've seen this happening in these:

this is a weird one

Reproduction steps

No response

Expected behavior

No response

Additional context

Restart and recreation of the docker container does not fix it.

@Typhonragewind Typhonragewind added the bug Something isn't working label Nov 8, 2022
@oae
Copy link
Owner

oae commented Nov 8, 2022

When you select a manga, kaizoku uses its title and passes it as a mangal search parameter to get detail from the first match. If the source doesn't give you matching manga when you search, it will download the wrong manga. Mangal CLI allows you to specify the index of the manga you want but doing this in an automated environment can cause problems.

I will look into possible solutions.

@oae oae linked a pull request Nov 16, 2022 that will close this issue
@oae oae closed this as completed in #30 Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants