Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated README including build/setup instructions #179

Closed
3 tasks
Malyuk-A opened this issue Jul 5, 2024 · 1 comment · Fixed by #180
Closed
3 tasks

Outdated README including build/setup instructions #179

Malyuk-A opened this issue Jul 5, 2024 · 1 comment · Fixed by #180

Comments

@Malyuk-A
Copy link

Malyuk-A commented Jul 5, 2024

Short

The README.md (especially in the oakestra-net/node-net-manager) is outdated, thus faulty. If you try to follow it to build/install/setup things it will eventually fail.

Proposal

Bring the README up to date, and or migrate it to the new OAK Docs entirely. Currently it does confuse more than it helps IMO.

A few examples:

  • Under the "Structure" header, a "install.sh" is mentioned, however it is no longer there - it is the build folder instead.
  • The install.sh (in the build folder) makes a lot of assumptions, e.g. where the user calls this script from (without any comment about where it should be invoked from), the tuncfg.json and netcfg.json are files that are (AFAIK) only acquired when installing the main OAK repo and fetching the NetManaget/NodeEngine resources - i.e. these two files are "magic-files" that are not part of the repo, especially not the build folder
  • etc.

Without the help of @smnzlnsk I would not have been able to build this - without reinventing the wheel.
He mentioned that he uses a custom makefile for this, so no one currently seems to be using these build instructions.

Solution

Bring these instructions up to date and or migrate them to the upcoming OAK Docs/Wiki.

Status

This ticket is there to inform others about the current state of things.

Checklist

  • Discussed
  • Solved
  • Tested
@Malyuk-A
Copy link
Author

Malyuk-A commented Jul 5, 2024

Also on a related note maybe - @smnzlnsk & I also discussed the structure of this repo in general.

We find it a bit strange that the NetManager is a folder inside the oakestra-net repo, "wrapped" in code that could/should arguably be part of the main-repo.

One thing we discussed is migrating these Python components to the main repo and only keeping the NetManager repo here and including it as a submodule in the main repo - Which could improve comprehension and building/starting things up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant