Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fixed required items for a Terraform ComponentDefinition #3257

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

zzxwill
Copy link
Collaborator

@zzxwill zzxwill commented Feb 15, 2022

If a Terraform variable is required, the item in OpenAPI schema
is required.

Signed-off-by: Zheng Xi Zhou zzxwill@gmail.com

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

If a Terraform variable is required, the item in OpenAPI schema
is required.

Signed-off-by: Zheng Xi Zhou <zzxwill@gmail.com>
@zzxwill zzxwill added the backport release-1.2 add this label will automatically backport this PR to release-1.2 branch label Feb 15, 2022
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #3257 (87a6e44) into master (2fd8b7b) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3257      +/-   ##
==========================================
+ Coverage   59.67%   59.74%   +0.06%     
==========================================
  Files         260      260              
  Lines       25526    25527       +1     
==========================================
+ Hits        15233    15250      +17     
+ Misses       8361     8350      -11     
+ Partials     1932     1927       -5     
Flag Coverage Δ
apiserver-unittests 28.00% <0.00%> (-0.14%) ⬇️
core-unittests 49.50% <100.00%> (+0.10%) ⬆️
e2e-multicluster-test 26.05% <0.00%> (+0.06%) ⬆️
e2e-rollout-tests 29.26% <0.00%> (-0.01%) ⬇️
e2etests 31.40% <0.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/utils/capability.go 79.80% <100.00%> (+0.04%) ⬆️
...ponentdefinition/componentdefinition_controller.go 80.00% <0.00%> (-5.56%) ⬇️
...es/policydefinition/policydefinition_controller.go 66.66% <0.00%> (ø)
...ntroller/common/rollout/rollout_plan_controller.go 62.05% <0.00%> (+1.53%) ⬆️
...dev/v1alpha2/application/application_controller.go 85.66% <0.00%> (+1.86%) ⬆️
...tepdefinition/workflowstepdefinition_controller.go 69.14% <0.00%> (+5.31%) ⬆️
...aits/traitdefinition/traitdefinition_controller.go 72.63% <0.00%> (+7.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fd8b7b...87a6e44. Read the comment docs.

@github-actions
Copy link

Successfully created backport PR #3258 for release-1.2.

@zzxwill zzxwill deleted the variable-required branch February 15, 2022 11:53
@zzxwill zzxwill mentioned this pull request Feb 18, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.2 add this label will automatically backport this PR to release-1.2 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants