Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AR with HT+HR is inaccurate #127

Open
2 tasks
acrylic-style opened this issue May 4, 2021 · 0 comments · May be fixed by #128
Open
2 tasks

AR with HT+HR is inaccurate #127

acrylic-style opened this issue May 4, 2021 · 0 comments · May be fixed by #128
Labels

Comments

@acrylic-style
Copy link
Collaborator

Describe the bug
AR with HT+HR is inaccurate (assuming the AR table on osu-wiki is correct)

This isn't a regression, it was broken since forever as you can see here:

ezpp/popup/index.js

Lines 177 to 192 in 7e1ceee

case (MOD_HT + MOD_HR): {
if (ar > 7) return 8.5;
if (ar < 4) {
ms = 2700 - 252 * ar;
} else if (ar < 5) {
ms = 1944 - 279 * (ar - 3);
} else {
ms = 1665 - 315 * (ar - 4);
}
if (ar < 6) {
return 15 - ms / 120;
} else if (ar > 7) {
return 13 - ms / 150;
}
return 15 - ms / 120;
}

To Reproduce
Steps to reproduce the behavior:

  1. calculate AR with HT+HR

Expected behavior
show correct AR

Screenshots
image

Environment (please complete the following information):

  • Browser:
    • Chrome
    • Firefox
  • Version: N/A (just calculated using code on main branch)
  • Beatmap URL: N/A
@acrylic-style acrylic-style linked a pull request May 4, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant