Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setuptargetrepos: copy paste error? #233

Open
pirat89 opened this issue Jun 5, 2019 · 2 comments · Fixed by #301
Open

setuptargetrepos: copy paste error? #233

pirat89 opened this issue Jun 5, 2019 · 2 comments · Fixed by #301
Labels
bug Something isn't working

Comments

@pirat89
Copy link
Member

pirat89 commented Jun 5, 2019

See https://github.com/oamg/leapp-repository/blob/master/repos/system_upgrade/el7toel8/actors/setuptargetrepos/actor.py#L83

which uses the repo_file var but in the loop it is not defined anywhere. It is used in different loop around the 60 line. That doesn't seems to be intention.
@pirat89 pirat89 added the bug Something isn't working label Jun 5, 2019
@fernflower
Copy link
Member

Thanks for opening an issue!
Found by #232

This was referenced Jun 5, 2019
Closed
Merged
@pirat89 pirat89 pinned this issue Jul 17, 2019
@bocekm bocekm mentioned this issue Aug 9, 2019
Merged
@bocekm
Copy link
Member

bocekm commented Aug 9, 2019

The actor was so hard to read that I needed to clean the code of the whole actor to find out what it even does: #301.

@bocekm bocekm mentioned this issue Oct 10, 2019
Closed
@bocekm bocekm reopened this Oct 10, 2019
@zhukovgreen zhukovgreen unpinned this issue Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@fernflower @pirat89 @bocekm