Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign possibility to affect RPM transaction #78

Open
pirat89 opened this issue Feb 18, 2019 · 0 comments
Open

Redesign possibility to affect RPM transaction #78

pirat89 opened this issue Feb 18, 2019 · 0 comments
Labels
documentation Docs/comments with no functional change enhancement New feature or request

Comments

@pirat89
Copy link
Member

pirat89 commented Feb 18, 2019

See the PR #73 for additional info (just related PR, doesn't resolve this issue). It is expected that there will be cases (e.g. PR #35) which will require additional actions during the RPM upgrade transaction (e.g. installation of specific RPMs) based on gathered facts about the syste (e.g. configuration of specific service). Current situation is confusing as the actor preparing the RPM transaction consumes FilteredRpmTransactionTasks msgs. However, people usually want to find something how to add new task and from that point the RpmTransactionTasks model is the one that looks they want to use it (even regarding additional actors, e.g. the transactionworkrounds actor.

We should rethink our current design a little here and modify it better, so it will be clear and intuitive what users should use.

NOTE: It is possible we will want to use the "filtered" data for reporting purposes - that means, by actors inside ChecksPhase - in furure.

@pirat89 pirat89 added enhancement New feature or request documentation Docs/comments with no functional change labels Feb 18, 2019
@pirat89 pirat89 changed the title Redisign possibility to affect RPM transaction Redesign possibility to affect RPM transaction Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs/comments with no functional change enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant