-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken queries on rerun #867
Conversation
/packit copr-build |
Based on your Packit configuration the settings of the @oamg/leapp Copr project would need to be updated as follows:
Diff of chroots: +epel-7-ppc64le Packit was unable to update the settings above as it is missing To fix this you can do one of the following:
Please retrigger the build, once the issue above is fixed. |
@dkubek Please rebase to fix packit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with local builds, since packit is broken until rebase.
Without this patch (both 7to8 and 8to9):
[root@leapp-20240719132659 ~]# /root/tmp_leapp_py3/leapp3 rerun FirstBoot
Traceback (most recent call last):
File "/root/tmp_leapp_py3/leapp3", line 6, in <module>
sys.exit(leapp.cli.main())
File "/root/tmp_leapp_py3/leapp/cli/__init__.py", line 51, in main
cli.command.execute('leapp version {}'.format(VERSION))
File "/root/tmp_leapp_py3/leapp/utils/clicmd.py", line 111, in execute
args.func(args)
File "/root/tmp_leapp_py3/leapp/utils/clicmd.py", line 133, in called
self.target(args)
File "/root/tmp_leapp_py3/leapp/cli/commands/rerun/__init__.py", line 46, in rerun
clone_context(last_context, context, db)
File "/root/tmp_leapp_py3/leapp/utils/audit/contextclone.py", line 105, in clone_context
_dup_metadata(db=db, oldcontext=oldcontext, newcontext=newcontext)
File "/root/tmp_leapp_py3/leapp/utils/audit/contextclone.py", line 74, in _dup_metadata
for row in _fetch_table_for_context(db, 'metadata', oldcontext):
File "/root/tmp_leapp_py3/leapp/utils/audit/contextclone.py", line 7, in _fetch_table_for_context
'''.format(table=table), (context,))
sqlite3.OperationalError: no such column: context
With this patch (7to8):
root@leapp-20240719142215 ~]# /root/tmp_leapp_py3/leapp3 rerun FirstBoot
==> Processing phase `FirstBoot`
====> * satellite_upgrader
Execute installer in the freshly booted system, to finalize Satellite configuration
====> * enable_rhsm_target_repos
On the upgraded target system, set release and enable repositories that were used during the upgrade
====> * insights_auto_register
Automatically registers system into Red Hat Insights
====> * network_manager_update_connections
Update NetworkManager connections.
====> * remove_systemd_resume_service
Remove systemd service to launch Leapp.
Debug output written to /var/log/leapp/leapp-upgrade.log
============================================================
REPORT OVERVIEW
============================================================
...
With this patch (8to9):
[root@leapp-20240719142203 ~]# /root/tmp_leapp_py3/leapp3 rerun FirstBoot
==> Processing phase `FirstBoot`
====> * enable_rhsm_target_repos
On the upgraded target system, set release and enable repositories that were used during the upgrade
====> * satellite_upgrader
Execute installer in the freshly booted system, to finalize Satellite configuration
====> * insights_auto_register
Automatically registers system into Red Hat Insights
====> * remove_systemd_resume_service
Remove systemd service to launch Leapp.
Debug output written to /var/log/leapp/leapp-upgrade.log
============================================================
REPORT OVERVIEW
============================================================
...
LGTM, but waiting for the rebase and test results
After the update to the leapp db table names, the rerun command fails. This commit fixes the issue by using the current schema.
/packit copr-build |
1 similar comment
/packit copr-build |
The currently failing tests passed in the previous run (no change pushed since) and the time-outing AWS tests are not relevant to this change. Merging. |
## Packaging - Start building for EL 9 in the upstream repository on COPR (oamg#855) ## Framework ### Enhancements - Minor update in the summary overview to highlight what is present in the pre-upgrade report (oamg#858) - Store metadata about actors, workflows, and dialogs inside leapp audit db (oamg#847, oamg#867) ## Leapp (tool) ### Enhancements - Implement singleton leapp execution to prevent multiple running leapp instances on the system in the same time (oamg#851) ## stdlib ### Fixes - Close properly all file descriptors when executing shell commands via `run` (oamg#880) ## Modifications - Code is now Python3.12 compatible (oamg#855)
## Packaging - Start building for EL 9 in the upstream repository on COPR (#855) ## Framework ### Enhancements - Minor update in the summary overview to highlight what is present in the pre-upgrade report (#858) - Store metadata about actors, workflows, and dialogs inside leapp audit db (#847, #867) ## Leapp (tool) ### Enhancements - Implement singleton leapp execution to prevent multiple running leapp instances on the system in the same time (#851) ## stdlib ### Fixes - Close properly all file descriptors when executing shell commands via `run` (#880) ## Modifications - Code is now Python3.12 compatible (#855)
After the update to the leapp db table names, the rerun command fails. This commit fixes the issue by using the current schema.
jira: https://issues.redhat.com/browse/RHEL-40363