Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdlib: remove the call function #467

Merged
merged 1 commit into from
Apr 4, 2019
Merged

stdlib: remove the call function #467

merged 1 commit into from
Apr 4, 2019

Conversation

pirat89
Copy link
Member

@pirat89 pirat89 commented Mar 27, 2019

We want to get rid of the subprocess library and we found the call
function as expendable as we want from people to use just run for
everything.

@pirat89 pirat89 requested review from vinzenz, artmello and a team March 27, 2019 17:22
@centos-ci
Copy link

Can one of the admins verify this patch?

@pirat89 pirat89 added wip unittest Requries Repo PR Use it when leapp-deps is changed labels Mar 27, 2019
@pirat89 pirat89 changed the title stdlib.call: Get rid of subprocess [WIP] stdlib.call: Get rid of subprocess Mar 27, 2019
@pirat89
Copy link
Member Author

pirat89 commented Mar 27, 2019

I will wait with writting of the tests as we want to discuss this solution yet. Maybe we will get rid of the call completely in favor of run. Just I have problem now with the default _logging_handler.

@pirat89 pirat89 changed the title [WIP] stdlib.call: Get rid of subprocess stdlib: remove the call function Apr 1, 2019
@pirat89 pirat89 removed Requries Repo PR Use it when leapp-deps is changed unittest wip labels Apr 2, 2019
We want to get rid of the subprocess library and we found the call
function as expendable as we want from people to use just `run` for
everything.
Copy link
Contributor

@artmello artmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pirat89 pirat89 merged commit 72f9680 into oamg:master Apr 4, 2019
MichalHe pushed a commit to MichalHe/leapp that referenced this pull request Aug 12, 2021
Migrate Quagga to FRR

Quagga has been replaced by FRR on RHEL 8 systems:
    https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/configuring_and_managing_networking/setting-your-routing-protocols_configuring-and-managing-networking

Actors automatically migrate the Quagga setup to FRR, except on systems using
the babeld daemon which has been dropped from FRR because of licensing issues.
If the use of the babeld daemon is detected, IPU is inhibited and user
is notified to reconfigure the system to use otherservices instead.
MichalHe pushed a commit to MichalHe/leapp that referenced this pull request Aug 12, 2021
## Packaging
- Bump required leapp-framework capability to 1.4 (oamg#642)

## Upgrade handling
### Fixes
- Fix comparison of the newest installed and booted kernel (oamg#600)
- Fix remediation command for ipa-server removal (oamg#617)
- Fix crash due to missing network interfaces during upgrade phases (oamg#625)
- Fix error with /boot/efi existing on non-EFI systems (oamg#627)
- Fix false positive detection of issue in /etc/default/grub that led into GRUB prompt (oamg#587)
- Fix syntax error in upgrade script (oamg#619)
- Inhibit upgrade with mount options in fstab that break mounting on RHEL 8 (oamg#639)
- Inhibit upgrade on s390x machines with /boot on a separate partition (oamg#641)
- Inhibit upgrade if multiple kernel-debug pkgs are installed (oamg#599)
- Remove the initial-setup package to avoid it asking for EULA acceptance during upgrade (oamg#626)
- Remove the *leapp-resume* service after the *FirstBoot* phase to prevent kill of the leapp process on `systemctl daemon-reload` (oamg#611)

### Enhancements
- Add upgrade support for SAP HANA (own upgrade path) (oamg#503)
- Allow upgrade with SCA enabled manifest (oamg#615)
- Add actors to migrate Quagga to FRR (oamg#467)
- Add stable uniq Key id for every dialog (oamg#618)
- Respect the *kernel-rt* package (oamg#600)

## Additional changes interesting for devels
- Add a possibility to overwrite virtualenv name using `$VENVNAME` (oamg#613)
- Update product certificates for RHEL 8.3 GA and 8.4 Beta/HTB (oamg#624)

Related leapp release: https://github.com/oamg/leapp/releases/tag/v0.12.0
@pirat89 pirat89 deleted the fix_call branch October 11, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants