Fix handling of debug/verbose in {pre,}upgrade #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously changes have been introduced that caused the debug/verbose information not to be stored correctly to the database, which led to different output behavior after reboot. (No debug/verbose output after resuming the execution) This patch changes the order when this data is processed so the configuration is updated correctly. JIRA-Taks: OAMG-3087 Signed-off-by: Vinzenz Feenstra <vfeenstr@redhat.com>
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines, pass tests and linter checks before it can be merged. If you want to re-run tests or request review, you can use following commands as a comment:
|
|
e2e tests |
|
Integration failed because we've recently added int.test that would depend on RHSM, but also few months ago we disabled RHSM (to increase reliability, ie avoid stage cdn). For now I've re-enabled RHSM to keep the coverage. If stage CDN will start acting out we'll see.. IOW, you can re-run tests of needed. |
|
e2e tests |
|
integration failed due to timeout. will reschedule |
|
e2e tests |
|
@AloisMahdal are the tests failing or is this just a CI problem? |
|
@drehak code is ok. it is error of tests or ci (summarizing what we discussed with @AloisMahdal in the past) |
|
e2e tests |
Merged
MichalHe
pushed a commit
to MichalHe/leapp
that referenced
this pull request
Aug 12, 2021
## Packaging - Bump required leapp-framework capability to 1.4 (oamg#642) ## Upgrade handling ### Fixes - Fix comparison of the newest installed and booted kernel (oamg#600) - Fix remediation command for ipa-server removal (oamg#617) - Fix crash due to missing network interfaces during upgrade phases (oamg#625) - Fix error with /boot/efi existing on non-EFI systems (oamg#627) - Fix false positive detection of issue in /etc/default/grub that led into GRUB prompt (oamg#587) - Fix syntax error in upgrade script (oamg#619) - Inhibit upgrade with mount options in fstab that break mounting on RHEL 8 (oamg#639) - Inhibit upgrade on s390x machines with /boot on a separate partition (oamg#641) - Inhibit upgrade if multiple kernel-debug pkgs are installed (oamg#599) - Remove the initial-setup package to avoid it asking for EULA acceptance during upgrade (oamg#626) - Remove the *leapp-resume* service after the *FirstBoot* phase to prevent kill of the leapp process on `systemctl daemon-reload` (oamg#611) ### Enhancements - Add upgrade support for SAP HANA (own upgrade path) (oamg#503) - Allow upgrade with SCA enabled manifest (oamg#615) - Add actors to migrate Quagga to FRR (oamg#467) - Add stable uniq Key id for every dialog (oamg#618) - Respect the *kernel-rt* package (oamg#600) ## Additional changes interesting for devels - Add a possibility to overwrite virtualenv name using `$VENVNAME` (oamg#613) - Update product certificates for RHEL 8.3 GA and 8.4 Beta/HTB (oamg#624) Related leapp release: https://github.com/oamg/leapp/releases/tag/v0.12.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously changes have been introduced that caused the debug/verbose
information not to be stored correctly to the database, which led to
different output behavior after reboot. (No debug/verbose output after
resuming the execution)
This patch changes the order when this data is processed so the
configuration is updated correctly.
JIRA-Taks: OAMG-3087
Signed-off-by: Vinzenz Feenstra vfeenstr@redhat.com