models: Fix warning about memebership check #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the value 'fields' of a Model could be potentially `None` which is not usuable for `x in y` kind of checks. This raised a pylint warning. This patch fixes this minority. Signed-off-by: Vinzenz Feenstra <vfeenstr@redhat.com>
alexandrepossebom
approved these changes
May 31, 2019
pirat89
added a commit
to pirat89/leapp
that referenced
this pull request
Jul 15, 2019
Packaging - Fix URL and Source0 in the SPEC file ===================================================================== Framework * Fixes - Add workround patch for the multiprocessing library - Exit non-zero on unhandled exceptions and errors - Fix actor library loading, so libs do not have to be imported in lexicographical order - Fix buf with mode inheritance and list field (oamg#203) - Fix warning about membership check of models when (oamg#503) - Load checkpoint ordered by `id` instead of timestamp to prevent issues with changed timezone (oamg#499) - Log on the ERROR level by default instead of DEBUG - Print usage to stderr * Enhancements - Add phase name checking to workflow parameters - Add the fetch_upgrade_report_raw() function to obtain raw report data - Create a dynamic configuration phase that allows creation of configuration for repository workflow - Functionalite getting actor and phase names when working with a workflow ===================================================================== Leapp * Fixes - Add checks of arguments for cmdline parameters - Load checkpoint ordered by `id` instead of timestamp to prevent issues with changed timezone (oamg#499) * Enhancements - Add JSON report generation - Add the preupgrade subcommand for the leapp tool that stops workflow execution after the Reports phase and display info about generated report ===================================================================== Snactor * Fixes - Add a simple logger to snactor discover command to avoid spurious output about missing logger - Add checks of arguments for cmdline parameters - Exit non-zero on unhandled exceptions and errors - Load checkpoint ordered by `id` instead of timestamp to prevent issues with changed timezone (oamg#499) ===================================================================== stdlib * Fixes - Add checks of arguments for cmdline parameters * Enhancements - Log output of commands to logfile (oamg#520) - stdlib: add option to `run()` to ignore exit code ===================================================================== Modifications - introduced conftest.py to utilize fixture mechanism, so fixture doesn't have to be imported explicitly in tests. - refactoring to satisfy linters
Merged
pirat89
added a commit
that referenced
this pull request
Jul 15, 2019
Packaging - Fix URL and Source0 in the SPEC file ===================================================================== Framework * Fixes - Add workround patch for the multiprocessing library - Exit non-zero on unhandled exceptions and errors - Fix actor library loading, so libs do not have to be imported in lexicographical order - Fix buf with mode inheritance and list field (#203) - Fix warning about membership check of models when (#503) - Load checkpoint ordered by `id` instead of timestamp to prevent issues with changed timezone (#499) - Log on the ERROR level by default instead of DEBUG - Print usage to stderr * Enhancements - Add phase name checking to workflow parameters - Add the fetch_upgrade_report_raw() function to obtain raw report data - Create a dynamic configuration phase that allows creation of configuration for repository workflow - Functionalite getting actor and phase names when working with a workflow ===================================================================== Leapp * Fixes - Add checks of arguments for cmdline parameters - Load checkpoint ordered by `id` instead of timestamp to prevent issues with changed timezone (#499) * Enhancements - Add JSON report generation - Add the preupgrade subcommand for the leapp tool that stops workflow execution after the Reports phase and display info about generated report ===================================================================== Snactor * Fixes - Add a simple logger to snactor discover command to avoid spurious output about missing logger - Add checks of arguments for cmdline parameters - Exit non-zero on unhandled exceptions and errors - Load checkpoint ordered by `id` instead of timestamp to prevent issues with changed timezone (#499) ===================================================================== stdlib * Fixes - Add checks of arguments for cmdline parameters * Enhancements - Log output of commands to logfile (#520) - stdlib: add option to `run()` to ignore exit code ===================================================================== Modifications - introduced conftest.py to utilize fixture mechanism, so fixture doesn't have to be imported explicitly in tests. - refactoring to satisfy linters
MichalHe
pushed a commit
to MichalHe/leapp
that referenced
this pull request
Aug 12, 2021
## Packaging - Bump required leapp-framework capability to 1.4 (oamg#642) ## Upgrade handling ### Fixes - Fix comparison of the newest installed and booted kernel (oamg#600) - Fix remediation command for ipa-server removal (oamg#617) - Fix crash due to missing network interfaces during upgrade phases (oamg#625) - Fix error with /boot/efi existing on non-EFI systems (oamg#627) - Fix false positive detection of issue in /etc/default/grub that led into GRUB prompt (oamg#587) - Fix syntax error in upgrade script (oamg#619) - Inhibit upgrade with mount options in fstab that break mounting on RHEL 8 (oamg#639) - Inhibit upgrade on s390x machines with /boot on a separate partition (oamg#641) - Inhibit upgrade if multiple kernel-debug pkgs are installed (oamg#599) - Remove the initial-setup package to avoid it asking for EULA acceptance during upgrade (oamg#626) - Remove the *leapp-resume* service after the *FirstBoot* phase to prevent kill of the leapp process on `systemctl daemon-reload` (oamg#611) ### Enhancements - Add upgrade support for SAP HANA (own upgrade path) (oamg#503) - Allow upgrade with SCA enabled manifest (oamg#615) - Add actors to migrate Quagga to FRR (oamg#467) - Add stable uniq Key id for every dialog (oamg#618) - Respect the *kernel-rt* package (oamg#600) ## Additional changes interesting for devels - Add a possibility to overwrite virtualenv name using `$VENVNAME` (oamg#613) - Update product certificates for RHEL 8.3 GA and 8.4 Beta/HTB (oamg#624) Related leapp release: https://github.com/oamg/leapp/releases/tag/v0.12.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the value 'fields' of a Model could be potentially
Nonewhich is not usuable for
x in ykind of checks. This raised a pylintwarning.
This patch fixes this minority.
Signed-off-by: Vinzenz Feenstra vfeenstr@redhat.com