Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Resolution Log CSDPR02 to CS02 #554

Closed
sthagen opened this issue May 20, 2022 · 7 comments
Closed

Comment Resolution Log CSDPR02 to CS02 #554

sthagen opened this issue May 20, 2022 · 7 comments
Assignees
Labels
CS02 Defects of CS01 with fixes targeting CS02 csaf 2.0 csaf 2.0 work CSDPR02_feedback Feedback on CSD02/CSDPR02 email To be sent via email to the TC non_material Similar to editorial this status is specific to public review editions oasis_tc_process OASIS TC process action

Comments

@sthagen
Copy link
Contributor

sthagen commented May 20, 2022

Comment Resolution Log

The table summarizes the comments that were received during the 15-day public review of the committee specification draft "Common Security Advisory Framework Version 2.0" and their resolution. Comments came to the csaf-comment and the CSAF TC mailing lists. The public review did start 15 April 2022 at 00:00 UTC and did end 29 April 2022 at 23:59 UTC.

A status of "Completed" in the Disposition column indicates that the editors have implemented the changes on which the TC decided, which are outlined in the Resolution column. It also is a hyperlink to the GitHub commit notice.

The item number is a hyperlink to the issue number in this OASIS TC CASF repository at https://github.com/oasis-tcs/csaf/.

Item # Date Commenter Description Date acknowledged Resolution Disposition
1 2022-04-27 Thomas Proell Remediations are confusing 2022-04-27 Discussed at TC call TC agrees. Editors added clarifications and explanations as needed.
2 2022-04-27 Thomas Schmidt Clarify aggregator requirements 2022-04-27 Discussed at TC call TC agrees. Editors added clarifications and explanations as needed.
3 2022-04-27 Thomas Schmidt Prettify Note 2022-04-27 Discussed at TC call TC agrees. Editors added clarifications and explanations as needed.
4 2022-04-27 Thomas Schmidt Improve title of mandatory test 6.1.30 2022-04-27 Discussed at TC call TC agrees. Editors added clarifications and explanations as needed.
5 2022-04-27 Thomas Schmidt Add missing reference [VERS] 2022-04-27 Discussed at TC call TC agrees. Editors added clarifications and explanations as needed.
6 2022-04-27 Thomas Schmidt Add missing reference [VEX-Just] 2022-04-27 Discussed at TC call TC agrees. Editors added clarifications and explanations as needed.
7 2022-04-27 Thomas Schmidt Add missing ] in example 16 2022-04-27 Discussed at TC call TC agrees. Editors added clarifications and explanations as needed.
8 2022-04-27 Thomas Schmidt Clarify purpose of product_id 2022-04-27 Discussed at TC call TC agrees. Editors added clarifications and explanations as needed.
9 2022-04-27 Thomas Schmidt Clarify purpose of group_ids 2022-04-27 Discussed at TC call TC agrees. Editors added clarifications and explanations as needed.
10 2022-04-27 Thomas Schmidt Clarify binding already in section 3 2022-04-27 Discussed at TC call TC agrees. Editors added clarifications and explanations as needed.
11 2022-04-28 Thomas Schmidt Reference security.txt as RFC9116 2022-04-28 Discussed at TC call TC agrees. Editors added clarifications and explanations as needed.
12 2022-04-28 Thomas Schmidt Fix leftover } 2022-04-28 Discussed at TC call TC agrees. Editors added clarifications and explanations as needed.
13 2022-04-28 Thomas Schmidt Fix example 4 2022-04-28 Discussed at TC call TC agrees. Editors added clarifications and explanations as needed.

Evaluation of Feedback

The editors consider above public comments as well as other more editorial feedback documented in issue(s) ... and classified/considered per pull request ... as Non-Material per OASIS TC process.

A motion has been issued during the TC meeting by Stefan Hagen on 2022-05-18 to promote the resulting revised work products to CS02 including non-material changes only.

To ease verification by anyone and to support the administration a separate release candidate archive containing the 4 standards track work products has been created and linked to this issue as well as noted in the motion as annotation in the minutes of meeting.

@sthagen sthagen added csaf 2.0 csaf 2.0 work email To be sent via email to the TC oasis_tc_process OASIS TC process action non_material Similar to editorial this status is specific to public review editions CS02 Defects of CS01 with fixes targeting CS02 CSDPR02_feedback Feedback on CSD02/CSDPR02 labels May 20, 2022
@santosomar
Copy link
Contributor

Updated the issue to include the link to the May 18, 2022 meeting minutes: https://github.com/oasis-tcs/csaf/blob/master/meeting_minutes/2022-05-18.md

@tschmidtb51
Copy link
Contributor

PR for the missing link has been added: #556.

@sthagen
Copy link
Contributor Author

sthagen commented May 29, 2022

@santosomar, @tschmidtb51, @chet-ensign The public review comment resolution log (CRL) is at https://github.com/oasis-tcs/csaf/blob/master/csaf_2.0/comment_resolution/log_from_csdpr02.md side by side with the log from CSDPR01. Now everything should be in place for progressing. Note: The CRL only documents the comments received during public review of CSD02 (CSDPR02) - additional non-material changes have been documented per the additional entries in the minutes of the previous TC meeting at https://github.com/oasis-tcs/csaf/blob/master/meeting_minutes/2022-05-18.md

@chet-ensign: Question: Do we need to replace the GitHub handle of @tom1972-de with a real "Given Family" name entry in the CRL to satisfy the OASIS TC Process requirements?

@chet-ensign
Copy link
Member

chet-ensign commented Jun 3, 2022 via email

@sthagen
Copy link
Contributor Author

sthagen commented Jun 10, 2022

@chet-ensign @santosomar @tschmidtb51 I created a release at https://github.com/oasis-tcs/csaf/releases/tag/cs-02-20220330-rc1 - please do not hesitate to ask if there are still questions or items missing. Thanks

@sthagen
Copy link
Contributor Author

sthagen commented Jun 10, 2022

@chet-ensign I also added some PDF rendition of the log at https://github.com/oasis-tcs/csaf/releases/download/cs-02-20220330-rc1/log_from_csdpr02.pdf to the release (updated the resolution log related list item (and placed a checksum file in addition for what it is worth).

Hope it helps,
Stefan

@tschmidtb51
Copy link
Contributor

@sthagen I guess we can close this one as the CS02 is published, right?

@sthagen sthagen closed this as completed Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CS02 Defects of CS01 with fixes targeting CS02 csaf 2.0 csaf 2.0 work CSDPR02_feedback Feedback on CSD02/CSDPR02 email To be sent via email to the TC non_material Similar to editorial this status is specific to public review editions oasis_tc_process OASIS TC process action
Projects
Development

No branches or pull requests

4 participants