Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Collections to X- Header list #44

Closed
varnerac opened this issue Feb 20, 2018 · 3 comments
Closed

Add Collections to X- Header list #44

varnerac opened this issue Feb 20, 2018 · 3 comments

Comments

@varnerac
Copy link

We provide two headers useful for pagination outside of the standard way:

  • X-TAXII-Date-Added-First
  • X-TAXII-Date-Added-Last

They are required for:

  • GET <api-root>/collections/objects/
  • GET <api-root>/collections/manifest/

They should also be required for GET /<api-root>/collections/, since it also requires pagination support.

@jordan2175
Copy link

So the first and last dates would just be the same for the case of a collection though right?

@jordan2175 jordan2175 added this to the TAXII-2.1-CSD01 milestone Feb 22, 2018
@varnerac
Copy link
Author

After the Slack discussions on pagination, I'm not convinced this is a good idea. Instead, I think pagination of Collections should be my the Collection id as @MarkDavidson suggested. Time-based pagination alone is inadequate.

@varnerac
Copy link
Author

OBE. No point in fixing his given added_after pagination in 2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants