Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request, which will contain all changes from ODF 1.3 CSD03 to ODF 1.3 CS02 (changes done before review phase) #30

Merged
merged 17 commits into from
Oct 12, 2020

Conversation

svanteschubert
Copy link
Contributor

Started with a single issue and will add fixes incrementally. Flagging this PullRequest therefore as a draft, until it is ready!
NOTE: Using a label as the "draft pull request feature" exists only for GitHub Team & Enterprise ;-)

@svanteschubert
Copy link
Contributor Author

Please note, I have fixed first the ODT, by using JEdit with archive PlugIn to access, edit and save the content.xml file within the ZIP.
Afterwards, I have been using an unzip batch file to unpack the ODT into the folder.
Therefore, if the change of the unzipped content.xml is correct, so is the ODT :-)

@svanteschubert
Copy link
Contributor Author

At this stage, decided to better stick to the TC-agreed wording from the former issue:
https://issues.oasis-open.org/browse/OFFICE-3873
Instead of following the wording recently suggested by Patrick:
https://lists.oasis-open.org/archives/office/202010/msg00016.html

@svanteschubert
Copy link
Contributor Author

svanteschubert commented Oct 9, 2020

Changes made so far:

  1. Updated the wording according to https://issues.oasis-open.org/browse/OFFICE-3873
  2. Updated IDs of deliverables references in the ODT (exchanged 'CSD03' to 'CS02' and 'CS01' to 'CSD03') 
  3. Fixing in part 3 the 'broken' link from 'http://citeseerx.ist.psu.edu/viewdoc/summary?doi=10.1.1.49.6093' to 'https://ctan.mirror.norbert-ruehl.de/biblio/bibtex/base/btxdoc.pdf'
  4. Fixing ODF 1.2 XML manually by removing ODF 1.3 attributes to become valid
  5. Fixing missing whitespace after MathML entities in HTML
  6. Generated new HTML & PDF documents

Copy link
Contributor

@mistmist mistmist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the .owl files need fixing

src/main/resources/odf1.3/OpenDocument-v1.3-metadata.owl Outdated Show resolved Hide resolved
docs/odf1.3/cs02/schemas/OpenDocument-v1.3-metadata.owl Outdated Show resolved Hide resolved
@mistmist

This comment has been minimized.

… metadata in content.xml - HTML & PDF regenerated
@mistmist mistmist merged commit 53a4779 into oasis-tcs:master Oct 12, 2020
@svanteschubert
Copy link
Contributor Author

The final summary of all (non-material) changes:

@svanteschubert svanteschubert changed the title Pull Request, which will contain all changes from ODF 1.3 CSD03 to ODF 1.3 CS02 Pull Request, which will contain all changes from ODF 1.3 CSD03 to ODF 1.3 CS02 (changes done before review phase) Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants