-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Definition of Actuator #67
Comments
Agree that the planned modification should be documented but also the Command definition for Actuator MUST be updated. Similarly, this confusion has influenced what we have included as actuator specifiers in SLPF and PF. Ill open an issue soon for the PF actuator profile to address that. With regards to questions:
|
So allowing multiple profiles seems like premature optimization - it has known issues to be resolved but unknown benefits. The only pro is that it doesn't have to be used; implementations can always specify a single profile in an array "[edr]", and if a use case that doesn't have any issues comes up, it could be accommodated without a breaking syntax change "[edr, pf]". I think profile should be singular, not a list.
|
This appears to be related to LS issue 90: oasis-tcs/openc2-oc2ls#90 |
Related to LS PR 404. Ideally should be addressed before finalizing v1.0 of the Architecture Spec as a CS. |
The Architecture Spec, being derived from the Language Spec, inherits the inconsistent meanings of "Actuator" that have existed since the beginning of OpenC2. The Glossary definition:
directly conflicts with the Command definition:
Since the English meaning of actuator is "a device that causes a machine or other device to operate", and the Command has always named the Actuator Profile that describes the operation to be performed, the choice of "actuator" as the Command property name was incorrect. Given the ongoing confusion caused by that choice, the property name should be fixed so that it does not conflict with the intended meaning: Command should have properties {action, target, args, profile(s)}.
Because modifying property names is a breaking change it will have to wait for a new OpenC2 major version (v2.0). In the meantime, the planned modification should be documented in v1.1, and all descriptions related to the "actuator" field should be made consistent with the field named "profile".
Decisions to be made:
Related to ER Issue #31 (oasis-tcs/openc2-ap-er#31)
The text was updated successfully, but these errors were encountered: