Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

Inputfields should not get emptied after a user clicked on the switch icon or picked another currency #14

Closed
pimato opened this issue Jan 17, 2018 · 4 comments
Assignees

Comments

@pimato
Copy link

pimato commented Jan 17, 2018

No description provided.

@pimato pimato changed the title Inputfields should not get removed after a user clicked on the switch icon or picked another currency Inputfields should not get emptied after a user clicked on the switch icon or picked another currency Jan 17, 2018
@gbalabasquer
Copy link
Contributor

@pimato
Mmm but which behavior you would use in this case?
Let's put some examples:

  1. I'm selling 1 ETH for DAI, a DAI value shows up. Then change DAI to MKR. This case I think is quite straight forward. I can imagine the MKR value will be calculated.
  2. I'm selling 1 ETH for DAI, a DAI value shows up. Then change ETH to MKR. Should I calculate selling 1 MKR and get the DAI value, or keep the DAI value and get how much MKR do we need?
  3. I'm selling 1 ETH for DAI, a DAI value shows up. Then we switch the coins, should we keep 1 ETH buying or the DAI amount as selling?

I think is even more complicate to decide when you are selecting the buy amount.
So we should put a simple rule to do always the same or specify case by case what we want to do.
I'm not sure if there is a natural way to decide, that is why I've opted to clean the inputs, so the user never gets confused.

@gbalabasquer gbalabasquer self-assigned this Jan 18, 2018
@peculiarity
Copy link

IMO the clearing should happen on every change. Person might forget what he intended to do and might forget to change the value. Calculating some scenarios just complicates everything. I don't see the problem with providing values on token change

@gbalabasquer
Copy link
Contributor

@pimato @peculiarity As we discussed with Thomas, we are leaving this issue on hold for now.

@pimato
Copy link
Author

pimato commented Feb 6, 2018

closed until it will be necessary to open it up again.

@pimato pimato closed this as completed Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants