This repository has been archived by the owner on Jun 10, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
When selling 0.03 ETH worth of MKR transaction fails with misleading MM comment #39
Labels
Comments
The fix is obvious, what is more worrying to me is that there is a:
|
@luke7211 The really relevant part in MM message is the |
@deepinit-arek If there is an error during gas estimation the MM window should not pup up at all as we should have seen this error before. Why our gasEstimation() did not fail, but MM failed () ? |
@luke7211 I think You are right. Ill try to have closer look at this. |
Need to review it in detail, but the minimum value is just an UI limit, a transaction failure has nothing to do with this limit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When you trade MKR-ETH and type 0.03 in the ETH box the MKR amount is below 0.03. Transaction will fail but with a very misleading error messagage leading user to believe that 1% threshold has been broken. This is repeatable.
The text was updated successfully, but these errors were encountered: