Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

When selling 0.03 ETH worth of MKR transaction fails with misleading MM comment #39

Closed
luke7211 opened this issue Mar 29, 2018 · 5 comments
Labels

Comments

@luke7211
Copy link
Contributor

luke7211 commented Mar 29, 2018

When you trade MKR-ETH and type 0.03 in the ETH box the MKR amount is below 0.03. Transaction will fail but with a very misleading error messagage leading user to believe that 1% threshold has been broken. This is repeatable.

image

@luke7211
Copy link
Contributor Author

The fix is obvious, what is more worrying to me is that there is a:

  1. Totally unintuitive message from MetaMask. Clearly sth went wrong and we did not catch it beforehand
  2. Even more troubling "Failed transaction probably due to exceeding 1% threshold" message - is there any way to differentiate that situation from other errors ?

@arkadiuszsz
Copy link

@luke7211 The really relevant part in MM message is the Transaction Error.
So when we do not allow situation where transaction would fail during gas estimation we should be on safe side (as far i can tell ).

@luke7211
Copy link
Contributor Author

@deepinit-arek If there is an error during gas estimation the MM window should not pup up at all as we should have seen this error before. Why our gasEstimation() did not fail, but MM failed () ?

@arkadiuszsz
Copy link

arkadiuszsz commented Mar 30, 2018

@luke7211 I think You are right. Ill try to have closer look at this.

@peculiarity peculiarity removed their assignment Apr 3, 2018
@peculiarity peculiarity reopened this Apr 6, 2018
@gbalabasquer
Copy link
Contributor

Need to review it in detail, but the minimum value is just an UI limit, a transaction failure has nothing to do with this limit.

gbalabasquer added a commit that referenced this issue Apr 23, 2018
gbalabasquer added a commit that referenced this issue Apr 24, 2018
gbalabasquer added a commit that referenced this issue Apr 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants