-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add named accounts #1398
Merged
Merged
Add named accounts #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/named-accounts-on-oasis
branch
from
May 6, 2024 14:20
c91d3ec
to
60a3e16
Compare
csillag
changed the title
[W.I.P.] Add named accounts on Oasis Consensus, Emerald, Sapphire
Add named accounts on Oasis Consensus, Emerald, Sapphire
May 6, 2024
csillag
changed the title
Add named accounts on Oasis Consensus, Emerald, Sapphire
Add named accounts on Oasis Consensus, Emerald, Sapphire and Pontus-X
May 7, 2024
csillag
force-pushed
the
csillag/named-accounts-on-oasis
branch
from
May 7, 2024 13:34
60a3e16
to
d339653
Compare
csillag
changed the title
Add named accounts on Oasis Consensus, Emerald, Sapphire and Pontus-X
Add named accounts
May 7, 2024
csillag
force-pushed
the
csillag/named-accounts-on-oasis
branch
2 times, most recently
from
May 7, 2024 13:36
5f7cfee
to
a7b311c
Compare
csillag
force-pushed
the
csillag/named-accounts-on-oasis
branch
from
May 9, 2024 05:04
a7b311c
to
bd90206
Compare
csillag
force-pushed
the
csillag/named-accounts-on-oasis
branch
3 times, most recently
from
May 10, 2024 15:41
b3b16b7
to
97533b7
Compare
lubej
reviewed
May 15, 2024
lubej
reviewed
May 15, 2024
csillag
force-pushed
the
csillag/named-accounts-on-oasis
branch
10 times, most recently
from
May 16, 2024 10:50
d46375e
to
c14df63
Compare
lukaw3d
reviewed
May 17, 2024
lukaw3d
reviewed
May 17, 2024
csillag
force-pushed
the
csillag/named-accounts-on-oasis
branch
11 times, most recently
from
May 21, 2024 15:06
cd8ca3d
to
4186bd7
Compare
- Load the Pontus-X account names - Load metadata for Oasis Consensus, Emerald and Sapphire - Support displaying account names - Support searching for named accounts by name
csillag
force-pushed
the
csillag/named-accounts-on-oasis
branch
from
May 21, 2024 15:27
4186bd7
to
5d6970c
Compare
lukaw3d
reviewed
May 21, 2024
lukaw3d
reviewed
May 21, 2024
lukaw3d
reviewed
May 21, 2024
lukaw3d
reviewed
May 21, 2024
lukaw3d
reviewed
May 21, 2024
src/app/pages/ConsensusAccountDetailsPage/ConsensusAccountDetailsCard.tsx
Show resolved
Hide resolved
lukaw3d
reviewed
May 21, 2024
csillag
force-pushed
the
csillag/named-accounts-on-oasis
branch
from
May 21, 2024 23:25
08356dd
to
7ceb3c1
Compare
lukaw3d
approved these changes
May 22, 2024
1 task
Up to now, only the searchTerm was passed on; now it gets the whole searchParams. This will make it possible to make more intelligent decisions about redirections.
When redirecting to an account from search results, only add the q=whatever query parameter to the end of the URL if the match was based on a name fragment, and not an address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some accounts to test with are listed here.