Fix the "zoom out" button #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/fix-zoom-out-button
branch
from
e46dfd6
to
d879415
Compare
|
something is wrong after zoom out
|
lubej
reviewed
May 14, 2024
lukaw3d
reviewed
May 14, 2024
csillag
force-pushed
the
csillag/fix-zoom-out-button
branch
2 times, most recently
from
c1ae9c9
to
ac8c5c6
Compare
lukaw3d
approved these changes
May 15, 2024
lukaw3d
requested changes
May 15, 2024
There was a problem hiding this comment.
oh, it is a strangely broken after zoom out
#1413 (comment)
Yeah I still need to debug why that happens. |
csillag
force-pushed
the
csillag/fix-zoom-out-button
branch
2 times, most recently
from
a527451
to
41d622c
Compare
Yeah, thanks, good catch. Fixed. |
buberdds
approved these changes
May 16, 2024
Now we are calling the selected thing "Area".
csillag
force-pushed
the
csillag/fix-zoom-out-button
branch
from
41d622c
to
29f6c82
Compare
lukaw3d
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier, the "zoom out" functionality (of the metaverse graph, in desktop mode) worked by selecting the consensus layer, which had the whole graph as designated area, so zooming to it actually zoomed out.
But then we wanted to make the consensus circle selectable and zoomable, so in #1404 the designated zoom are has been changed. This made is possible to zoom in on selection (on mobile), but has broken the zoom out button (on desktop). (see #1404 (comment) )
So now we are fixing this be introducing a special "fake" layer, just for the components in/around the layer selector, for zooming out: the "universe layer". This layer will have the whole graph as designated zoom area, so selecting this layer will zoom out, while the consensus layer can have it's small area.
Also, since it's no longer always a layer, we are now calling the selection on the graph "area". All related props and functions have been renamed accordingly.