go/archive-mode: disable runtime P2P if archive mode is used #4775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
force-pushed
the
ptrus/feature/archive-node-p2p
branch
3 times, most recently
from
b46b5a2
to
befd758
Compare
ptrus
requested review from
kostko,
Yawning,
peterjgilbert and
pro-wh
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4775 +/- ##
==========================================
+ Coverage 66.82% 66.88% +0.05%
==========================================
Files 448 451 +3
Lines 50246 50294 +48
==========================================
+ Hits 33579 33638 +59
- Misses 12492 12495 +3
+ Partials 4175 4161 -14
Continue to review full report at Codecov.
|
kostko
reviewed
Jun 3, 2022
go/oasis-node/cmd/node/node.go
Outdated
Comment on lines
277
to
279
| if genesisDoc.Registry.Parameters.DebugAllowUnroutableAddresses { | ||
| p2p.DebugForceAllowUnroutableAddresses() | ||
| } |
go/worker/common/p2p/nop.go
Outdated
| } | ||
|
|
||
| // NewMock creates a new no-op mock P2P node. | ||
| func NewMock() api.Service { |
There was a problem hiding this comment.
I would rather call it NewNop (or similar) as mock could imply it is only used in tests as it provides mock responses.
go/worker/common/p2p/nop.go
Outdated
|
|
||
| // Implements api.Service. | ||
| func (p *nopP2P) Name() string { | ||
| return "mock p2p" |
There was a problem hiding this comment.
Suggested change
| return "mock p2p" | |
| return "no-op p2p" |
go/worker/common/p2p/nop.go
Outdated
| "github.com/oasisprotocol/oasis-core/go/worker/common/p2p/rpc" | ||
| ) | ||
|
|
||
| // nopP2P is a no-op mock peer-to-peer node. |
There was a problem hiding this comment.
Suggested change
| // nopP2P is a no-op mock peer-to-peer node. | |
| // nopP2P is a no-op peer-to-peer node that does not propagate anything. |
go/worker/common/p2p/rpc/client.go
Outdated
| maxPeerResponseTime time.Duration, | ||
| opts ...CallOption, | ||
| ) (PeerFeedback, error) { | ||
| return nil, fmt.Errorf("unsupported: mock p2p") |
There was a problem hiding this comment.
Suggested change
| return nil, fmt.Errorf("unsupported: mock p2p") | |
| return nil, fmt.Errorf("unsupported: p2p is disabled") |
go/worker/common/p2p/rpc/client.go
Outdated
| maxParallelRequests uint, | ||
| opts ...CallMultiOption, | ||
| ) ([]interface{}, []PeerFeedback, error) { | ||
| return nil, nil, fmt.Errorf("unsupported: mock p2p") |
There was a problem hiding this comment.
Suggested change
| return nil, nil, fmt.Errorf("unsupported: mock p2p") | |
| return nil, nil, fmt.Errorf("unsupported: p2p is disabled") |
go/worker/common/p2p/rpc/client.go
Outdated
| @@ -215,6 +215,33 @@ type Client interface { | |||
| ) ([]interface{}, []PeerFeedback, error) | |||
| } | |||
|
|
|||
| type nopClient struct { | |||
There was a problem hiding this comment.
Maybe move the nop client and peer manager into a separate nop.go.
go/worker/common/p2p/rpc/peermgmt.go
Outdated
| @@ -325,6 +353,10 @@ func (mgr *peerManager) peerProtocolWatcher() { | |||
|
|
|||
| // NewPeerManager creates a new peer manager for the given protocol. | |||
| func NewPeerManager(p2p P2P, protocolID protocol.ID, stickyPeers bool) PeerManager { | |||
| if p2p.GetHost() == nil { | |||
| // Mock P2P service, use the mock peer manager. | |||
There was a problem hiding this comment.
Suggested change
| // Mock P2P service, use the mock peer manager. | |
| // No P2P service, use the no-op peer manager. |
ptrus
force-pushed
the
ptrus/feature/archive-node-p2p
branch
2 times, most recently
from
4bcec27
to
6db6ce7
Compare
kostko
approved these changes
Jun 6, 2022
ptrus
force-pushed
the
ptrus/feature/archive-node-p2p
branch
from
6db6ce7
to
80c39d0
Compare
ptrus
force-pushed
the
ptrus/feature/archive-node-p2p
branch
from
80c39d0
to
2657e28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.