go/runtime/registry: allow client nodes to run sgx runtimes #4832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhynes
requested review from
kostko,
Yawning,
peterjgilbert,
pro-wh and
ptrus
as code owners
nhynes
changed the title
nhynes
force-pushed
the
nhynes/client-node-sgx
branch
from
3468f44
to
29bea1c
Compare
Codecov Report
@@ Coverage Diff @@
## master #4832 +/- ##
==========================================
- Coverage 66.74% 66.61% -0.13%
==========================================
Files 452 452
Lines 50336 50338 +2
==========================================
- Hits 33597 33534 -63
- Misses 12586 12643 +57
- Partials 4153 4161 +8
Continue to review full report at Codecov.
|
kostko
reviewed
Jun 30, 2022
nhynes
force-pushed
the
nhynes/client-node-sgx
branch
from
29bea1c
to
1a4c2a0
Compare
kostko
reviewed
Jul 1, 2022
go/runtime/registry/config.go
Outdated
| @@ -37,6 +37,9 @@ const ( | |||
| CfgRuntimePaths = "runtime.paths" | |||
| // CfgSandboxBinary configures the runtime sandbox binary location. | |||
| CfgSandboxBinary = "runtime.sandbox.binary" | |||
| // CfgRuntimeEnv sets the runtime environment. Setting an environment that does not | |||
There was a problem hiding this comment.
Looks like something is up with the linter, maybe since the update to Go 1.18?
Suggested change
| // CfgRuntimeEnv sets the runtime environment. Setting an environment that does not | |
| // CfgRuntimeEnvironment sets the runtime environment. Setting an environment that does not |
There was a problem hiding this comment.
Okay, this is totally messed up. I'm going to fix the linter. Sorry for using so much jernej-lint. Next time won't have issues!
nhynes
force-pushed
the
nhynes/client-node-sgx
branch
from
1a4c2a0
to
e5d2e55
Compare
kostko
approved these changes
Jul 1, 2022
nhynes
force-pushed
the
nhynes/client-node-sgx
branch
from
e5d2e55
to
df7c7ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows client nodes to run SGX runtimes, which enables them to request keys from a (privately) peered key manager. The
RuntimeDebugForceELFflag was replaced with a more general one. The former one doesn't seem to be used in this repo, so it should be okay.