-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime/consensus/verifier: Support trust root consensus layer upgrades #4903
Conversation
e7dca1b
to
e00dc3a
Compare
Codecov Report
@@ Coverage Diff @@
## master #4903 +/- ##
==========================================
+ Coverage 66.60% 66.70% +0.10%
==========================================
Files 464 464
Lines 50981 50984 +3
==========================================
+ Hits 33955 34011 +56
+ Misses 12834 12795 -39
+ Partials 4192 4178 -14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
5fd68c9
to
77e39bd
Compare
260040a
to
ea911f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, thanks! Just one minor thing that could maybe be changed.
@@ -242,6 +242,15 @@ func (h *runtimeHostHandler) Handle(ctx context.Context, body *protocol.Body) (* | |||
Block: *lb, | |||
}}, nil | |||
} | |||
if body.HostFetchGenesisHeightRequest != nil { | |||
doc, err := h.consensus.GetGenesisDocument(ctx) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also introduce the GetGenesisBlock
method to the consensus backend.
dbdd00f
to
c77ee97
Compare
Tested locally. Without changes compute workers are stuck with error messages
Consensus verifier failed to initialize
.With changes compute workers report error message
Not enough trust to accept new chain context
when there is not enough trust to do the transitionor
Failed to accept new chain context
if new light blocks are invalid (e.g. invalid time, height, hash, ...).