Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/client: Better handle latest round queries with verification #5123

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

kostko
Copy link
Member

@kostko kostko commented Jan 10, 2023

When a query is requesting to be executed against the latest round and the runtime reports a consensus verifier error, use an earlier round instead as the latest round may not yet be verifiable by the light client as it needs to wait for the validator signatures.

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #5123 (9b520ae) into master (9dcdfef) will increase coverage by 0.04%.
The diff coverage is 33.89%.

@@            Coverage Diff             @@
##           master    #5123      +/-   ##
==========================================
+ Coverage   66.93%   66.97%   +0.04%     
==========================================
  Files         496      496              
  Lines       53253    53271      +18     
==========================================
+ Hits        35643    35679      +36     
+ Misses      13277    13258      -19     
- Partials     4333     4334       +1     
Impacted Files Coverage Δ
go/consensus/tendermint/apps/beacon/backend_vrf.go 58.89% <ø> (ø)
.../consensus/tendermint/apps/registry/state/state.go 61.28% <0.00%> (ø)
...consensus/tendermint/apps/registry/transactions.go 57.14% <0.00%> (-0.09%) ⬇️
go/registry/api/api.go 55.00% <15.38%> (+1.21%) ⬆️
go/worker/client/committee/node.go 68.39% <31.03%> (-5.16%) ⬇️
go/common/node/node.go 71.07% <100.00%> (ø)
go/consensus/tendermint/tests/genesis/genesis.go 91.78% <100.00%> (ø)
go/oasis-node/cmd/registry/node/node.go 43.22% <100.00%> (ø)
go/registry/tests/tester.go 92.48% <100.00%> (ø)
go/worker/registration/worker.go 64.13% <100.00%> (+0.16%) ⬆️
... and 45 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kostko kostko marked this pull request as ready for review January 10, 2023 16:01
go/worker/client/committee/node.go Outdated Show resolved Hide resolved
@kostko kostko force-pushed the kostko/fix/query-verifail-latest branch 2 times, most recently from 4a3630f to d90e947 Compare January 10, 2023 17:12
When a query is requesting to be executed against the latest round and
the runtime reports a consensus verifier error, use an earlier round
instead as the latest round may not yet be verifiable by the light
client as it needs to wait for the validator signatures.
@kostko kostko force-pushed the kostko/fix/query-verifail-latest branch from d90e947 to 9b520ae Compare January 11, 2023 12:54
@kostko kostko merged commit fe87383 into master Jan 11, 2023
@kostko kostko deleted the kostko/fix/query-verifail-latest branch January 11, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants