-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: remove some Emerald references #306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hah I have an almost identical commit on my machine :)
Thank you!
LGTM pending the unresolved comments.
As per the comment https://github.com/oasisprotocol/oasis-indexer/pull/306/files#r1095643489, here are the two tests that I ran to verify that this PR basically resolves https://app.clickup.com/t/3u9y285 and makes us ready to use multiple analyzers. In both tests, I ran Test 1 - config: analyzers:
emerald:
from: 1_003_298 # round at Damask genesis
to: 1_003_308 # 10 blocks
sapphire:
from: 1_003_298 # round at Damask genesis
to: 1_003_308 # 10 blocks No differences in emerald queries on the resulting DB. This strongly suggests no erroneous double dead-reckoning, or similar overlap between analyzers' output. Test 2 - config: analyzers:
emerald:
from: 1_003_298 # round at Damask genesis
to: 1_003_318 # 20 blocks
sapphire:
from: 1_003_308 # emerald + 10
to: 1_003_328 # emerald + 10 No difference in any queries, except |
thanks for the testing! |
c65f189
to
b44de02
Compare
constructing a runtime analyzer now takes an analyzer.Runtime parameter
cross reference #305
last (?) step of https://app.clickup.com/t/3u9y285