Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock out obviously unwise/unintended operations behind a configuration option #243

Open
Yawning opened this issue Jan 31, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request p:1 Priority: core feature

Comments

@Yawning
Copy link

Yawning commented Jan 31, 2022

For emphasis, and because people will inevitably freak out about certain things being prohibited: IF THIS IS IMPLEMENTED YOU CAN STILL DO THESE THINGS, IT WILL JUST TAKE EXTRA CONFIGURATION.

Following in the spirit of oasis-core (that stole the idea from sendmail), extremely unwise/unsafe/unintended operations should be strictly prohibited unless the wallet is explicitly configured to allow such behavior (The DontBlameSendmail approach).

Off the top of my head, the following operations should be prohibited by default:

This would be in addition to the existing warnings (that the wallet should retain). But honestly, these operations are both uncommon, and typically "a really bad idea" enough to the point where flat out disabling them by default is the sensible thing to do.

@Yawning Yawning added enhancement New feature or request p:1 Priority: core feature labels Jan 31, 2022
@Yawning
Copy link
Author

Yawning commented Jun 13, 2022

Since this has come up recently. Safety features that rely on reading comprehension are inadequate. DISABLE, not warn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p:1 Priority: core feature
Projects
None yet
Development

No branches or pull requests

2 participants