Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update footer text #1941

Merged

Conversation

rochelle-norman
Copy link

Closes #1910

src/locales/en/translation.json Outdated Show resolved Hide resolved
src/app/components/Footer/index.tsx Outdated Show resolved Hide resolved
src/app/components/Footer/index.tsx Outdated Show resolved Hide resolved
src/app/components/Footer/index.tsx Show resolved Hide resolved
src/app/components/Footer/index.tsx Outdated Show resolved Hide resolved
@rochelle-norman rochelle-norman force-pushed the rn/feat/update-footer-text branch 2 times, most recently from f9f47db to bdc3fdc Compare May 22, 2024 14:41
@buberdds
Copy link
Contributor

Nice work btw, thank you. I will add three more comments, so if you are running out of time or patience we can combine forces.

@buberdds
Copy link
Contributor

buberdds commented May 23, 2024

When you run yarn test you will see that some tests will need some tweaks.
For updating snapshots run yarn jest -u
Other one will fail because link with hash is not longer visible. Either simulate click using import userEvent from '@testing-library/user-event' or remove the test (we can refactor it in the future)

@buberdds buberdds force-pushed the rn/feat/update-footer-text branch 3 times, most recently from ffce44c to 85275e9 Compare May 24, 2024 09:44
@buberdds buberdds force-pushed the rn/feat/update-footer-text branch from 85275e9 to a02ca65 Compare May 24, 2024 09:46
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.48%. Comparing base (8d98512) to head (85275e9).
Report is 33 commits behind head on master.

Current head 85275e9 differs from pull request most recent head a02ca65

Please upload reports for the commit a02ca65 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1941      +/-   ##
==========================================
- Coverage   80.56%   80.48%   -0.08%     
==========================================
  Files         202      203       +1     
  Lines        5247     5278      +31     
  Branches      960      968       +8     
==========================================
+ Hits         4227     4248      +21     
- Misses       1020     1030      +10     
Flag Coverage Δ
cypress 44.60% <75.00%> (+0.05%) ⬆️
jest 76.46% <100.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/app/components/Footer/index.tsx 93.18% <100.00%> (+2.27%) ⬆️

... and 6 files with indirect coverage changes

@buberdds buberdds merged commit e1da102 into oasisprotocol:master May 24, 2024
10 of 11 checks passed
@buberdds
Copy link
Contributor

Thanks!

lukaw3d added a commit that referenced this pull request Jul 30, 2024
Example of existing translation that was broken:
`"version": "Različica <ReleaseLink/> (<CommitLink/>) zgrajena {{buildTime}}"`

Reverts part of #1941 and #1961.
lukaw3d added a commit that referenced this pull request Jul 30, 2024
Example of existing translation that was broken:
`"version": "Različica <ReleaseLink/> (<CommitLink/>) zgrajena {{buildTime}}"`

Reverts part of #1941 and #1961.
lukaw3d added a commit that referenced this pull request Jul 31, 2024
Example of existing translation that was broken:
`"version": "Različica <ReleaseLink/> (<CommitLink/>) zgrajena {{buildTime}}"`

Reverts part of #1941 and #1961.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update footer text
2 participants