Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more transaction fields smaller #2010

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Make more transaction fields smaller #2010

merged 2 commits into from
Jul 16, 2024

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Jul 16, 2024

Related to #2003

Before After
localhost_3000_account_oasis1qqekv2ymgzmd8j2s2u7g0hhc7e77e654kvwqtjwm(extension375x600 + scrollbar) (1) localhost_3000_account_oasis1qqekv2ymgzmd8j2s2u7g0hhc7e77e654kvwqtjwm(extension375x600 + scrollbar)

@lukaw3d lukaw3d requested a review from buberdds July 16, 2024 15:24
Copy link

github-actions bot commented Jul 16, 2024

Deployed to Cloudflare Pages

Latest commit: a22f018b4f93c8c902842fefbfd7f91714dfc1ba
Status:✅ Deploy successful!
Preview URL: https://5d3369df.oasis-wallet.pages.dev

Copy link
Contributor

@buberdds buberdds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh we forgot about playwright in #2009

@lukaw3d
Copy link
Member Author

lukaw3d commented Jul 16, 2024

Fixed in 03d11db
:/ playwright passing is still not required for auto-merge, I guess from when Transak was failing

@lukaw3d lukaw3d enabled auto-merge July 16, 2024 16:48
@lukaw3d lukaw3d merged commit 2f1b901 into master Jul 16, 2024
13 checks passed
@lukaw3d lukaw3d deleted the lw/smaller-tx-fields branch July 16, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants