-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update state of wallets after changing network #316
Conversation
656c8f2
to
d9c4b6f
Compare
Mega-Linter status: ✅ SUCCESS
See errors details in artifact Mega-Linter reports on GitHub Action page |
// Reload wallet balances if network changes | ||
useEffect(() => { | ||
for (const wallet of Object.values(wallets)) { | ||
dispatch(walletActions.fetchWallet(wallet)) | ||
} | ||
}, [dispatch, wallets, selectedNetwork]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I'm not sure what is the best practice for combining different sagas (network => wallet), so this just follows accountActions.fetchAccount
implementation
Hmm... I tried to test this locally and got:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message should probably be:
Update wallet's state after changing network
d9c4b6f
to
b0e5c9c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #316 +/- ##
===========================================
+ Coverage 90.82% 90.87% +0.05%
===========================================
Files 96 96
Lines 1548 1557 +9
Branches 269 269
===========================================
+ Hits 1406 1415 +9
Misses 142 142
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Did you I just used |
No.
I used:
|
ah, so equivalent of |
https://testnet.grpc.oasis.dev/oasis-core.Consensus/GetGenesisDocument is returning 503 with headers
|
Yeah, that was the issue. It works now. |
b0e5c9c
to
b079e99
Compare
Fixes #270
Fixes #305