Use webext-redux in extension #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buberdds
changed the title
lukaw3d
reviewed
Apr 6, 2022
src/app/components/Toolbar/Features/NetworkSelector/__tests__/index.test.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+7
to
+17
| export const useRouteRedirects = () => { | ||
| const activeWalletIndex = useSelector(selectActiveWalletId) | ||
| const address = useSelector(selectAddress) | ||
| const history = useHistory() | ||
|
|
||
| useEffect(() => { | ||
| if (typeof activeWalletIndex !== 'undefined' && address) { | ||
| history.push(`/account/${address}`) | ||
| } | ||
| }, [activeWalletIndex, address, history]) | ||
| } |
There was a problem hiding this comment.
For a separate PR:
Oh this is tough. It was an effect in saga before (https://github.com/oasisprotocol/oasis-wallet-web/blob/5cebb40/src/app/state/wallet/saga.ts#L150) but saga now runs in background page.
One benefit of this is: when you open a popup with stored state, it redirects to your wallet.
One issue is: it always redirects. Even if you have chrome-extension://jplembhokmkioddbchbohdfkmjdmepbb/popup.html#/create-wallet open as a tab, and reload.
Use cases:
- when active wallet changes, redirect to it
- when clicking extension icon to open popup, redirect to active wallet (ideally use history.replace)
- or (Tadej's preference) clicking extension icon to open popup redirects to last url (ideally use history.replace)
(conflicts with "not to keep your routes in your Redux store at all" recommendation)
- or (Tadej's preference) clicking extension icon to open popup redirects to last url (ideally use history.replace)
- when reloading an existing popup, don't redirect
- when opening popup with specific URL (e.g. to confirm dapp action), don't redirect
There was a problem hiding this comment.
ahh yes for "don't redirect" we will need to compare with prev value. I will move this task to clickup.
lukaw3d
reviewed
Apr 6, 2022
lukaw3d
reviewed
Apr 6, 2022
lukaw3d
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use
webext-reduxand reuse what we have in web in a new extension I think we need to:connected-router. While redux state was updated correctly, popup routing was never affected by history push called from saga. Moreover, this lib is not working with newer router and react router team recommend to "not to keep your routes in your Redux store at all".It would be good if someone had time for similar research maybe we don't need such overhaul.