Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve descriptions of transactions #958

Merged
merged 5 commits into from
Aug 16, 2022
Merged

Improve descriptions of transactions #958

merged 5 commits into from
Aug 16, 2022

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Aug 5, 2022

Partially addresses #752

Before After
localhost_3000_account_oasis1qz78ap0456g2rk7j6rmtvasc9v2kjhz2s58qgj90 (1) localhost_3000_account_oasis1qz78ap0456g2rk7j6rmtvasc9v2kjhz2s58qgj90

@github-actions
Copy link

github-actions bot commented Aug 5, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 6 0 0.03s
✅ GIT git_diff yes no 0.01s
✅ JSON eslint-plugin-jsonc 4 0 0 0.98s
✅ JSON jsonlint 4 0 0.97s
✅ JSON prettier 4 0 0 0.65s
✅ JSON v8r 4 0 2.46s
✅ TSX eslint 1 0 0 5.18s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #958 (1b4e76f) into master (a30f319) will decrease coverage by 0.44%.
The diff coverage is 33.33%.

❗ Current head 1b4e76f differs from pull request most recent head e0584b8. Consider uploading reports for the commit e0584b8 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #958      +/-   ##
==========================================
- Coverage   88.58%   88.13%   -0.45%     
==========================================
  Files          99       98       -1     
  Lines        1708     1703       -5     
  Branches      396      390       -6     
==========================================
- Hits         1513     1501      -12     
- Misses        195      202       +7     
Flag Coverage Δ
cypress 58.18% <0.00%> (+0.05%) ⬆️
jest 78.94% <33.33%> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Transaction/index.tsx 75.36% <33.33%> (-8.25%) ⬇️
...ages/StakingPage/Features/DelegationList/index.tsx 83.78% <0.00%> (-1.59%) ⬇️
src/app/components/TimeToEpoch/index.tsx

@buberdds
Copy link
Contributor

buberdds commented Aug 5, 2022

  • imo we don't have to duplicate amount in title. So it can look like this:
    "Type(title) addr, date, amount" and not "Type+amount, addr, date, amount". It's easier to "scan" page when title is more compact
  • Title Method root hash.executor might be still not clear for users
  • known transaction types are distinguish with unique icon

#752

@lukaw3d
Copy link
Member Author

lukaw3d commented Aug 5, 2022

  • Removing amounts out of title: I agree for transfers, especially of less pretty amounts. But I like the amount in additional context when setting allowance - maybe the amount shouldn't even be displayed on the right
  • I don't know what we'll do with ExecutorCommits. Potentially we could fetch their details and display events that apply to this account. Some of those events will already be displayed as transactions, though some might not be. Anyway I just removed the scary "Unrecognized transaction" prefix
  • Maybe ATM icon https://icons.grommet.io/?s=atm for setting allowance 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants