You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging #958 (1b4e76f) into master (a30f319) will decrease coverage by 0.44%.
The diff coverage is 33.33%.
❗ Current head 1b4e76f differs from pull request most recent head e0584b8. Consider uploading reports for the commit e0584b8 to get more accurate results
imo we don't have to duplicate amount in title. So it can look like this:
"Type(title) addr, date, amount" and not "Type+amount, addr, date, amount". It's easier to "scan" page when title is more compact
Title Method root hash.executor might be still not clear for users
known transaction types are distinguish with unique icon
Removing amounts out of title: I agree for transfers, especially of less pretty amounts. But I like the amount in additional context when setting allowance - maybe the amount shouldn't even be displayed on the right
I don't know what we'll do with ExecutorCommits. Potentially we could fetch their details and display events that apply to this account. Some of those events will already be displayed as transactions, though some might not be. Anyway I just removed the scary "Unrecognized transaction" prefix
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #752