Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #308: oatpp::base::memory::MemoryPool::freeByEntryHeader()]: Invalid EntryHeader #314

Merged
merged 3 commits into from Oct 1, 2020
Merged

Issue #308: oatpp::base::memory::MemoryPool::freeByEntryHeader()]: Invalid EntryHeader #314

merged 3 commits into from Oct 1, 2020

Conversation

pcapdump
Copy link
Contributor

@pcapdump pcapdump commented Oct 1, 2020 •
edited

@pcapdump pcapdump marked this pull request as ready for review October 1, 2020 09:26
@pcapdump pcapdump mentioned this pull request Oct 1, 2020
Closed
@pcapdump
Copy link
Contributor Author

pcapdump commented Oct 1, 2020

@lganzzzo ,

Please wait with this PR.
During adjusting it to pass your unit tests it somehow has lost its issue-fixing feature.

I'm re-checking it again.

@pcapdump pcapdump marked this pull request as draft October 1, 2020 17:58
@lganzzzo lganzzzo marked this pull request as ready for review October 1, 2020 23:09
@lganzzzo
Copy link
Member

lganzzzo commented Oct 1, 2020

I like these changes.
Great work!

@lganzzzo lganzzzo merged commit 8a15cb4 into oatpp:master Oct 1, 2020
@lganzzzo
Copy link
Member

lganzzzo commented Oct 2, 2020

Strange but this PR causes Ubuntu builds to fail for

@lganzzzo lganzzzo mentioned this pull request Oct 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pcapdump @lganzzzo