Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter authentication breaks with undefined in place of String value #47

Closed
fzero opened this issue Dec 16, 2014 · 1 comment
Closed

Comments

@fzero
Copy link

fzero commented Dec 16, 2014

I've just found this bug while trying Oauth.io. The quickfix was simply to typecast the value with String() in the /dist JS code but you'll probably want to port it to your CoffeeScript source.

The issue is at https://github.com/oauth-io/oauth-js/blob/master/dist/oauth.js#L767

I fixed it locally changing it from:

client_states[k] = v.replace(/\s+/g, "");

to:

client_states[k] = String(v).replace(/\s+/g, "");
@zachelrath
Copy link

I experienced this as well with other authentication providers (e.g. Salesforce) --- workaround by @fzero worked for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants