Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #234 (Improve Example) #235

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Fix #234 (Improve Example) #235

merged 3 commits into from
Jul 1, 2024

Conversation

danielfett
Copy link
Member

Fixes #234

bc-pi
bc-pi requested changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@bc-pi bc-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how many bytes would a vct#integrity byte if a vct#integrity could byte integrity?

awoie
awoie requested changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@awoie awoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me but @bc-pi comment has to be fixed

bc-pi added 2 commits July 1, 2024 11:04
@bc-pi
comment open for 3 weeks, dr. fett on holiday, commiting my own sugge…
0cf973f 
…stion to at least be not wrong, etc., ffs, etc.
@bc-pi
comment open for 3 weeks, dr. fett on holiday, commiting my own sugge…
1e73ea0 
…stion to at least be not wrong, etc., ffs, etc.
@awoie awoie merged commit a8eedd9 into main Jul 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awoie awoie awoie approved these changes

@bc-pi bc-pi bc-pi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Label example in Section 6.1
3 participants
@danielfett @awoie @bc-pi