Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rack version in Gemfile to ~> 2.0 #278

Closed
wants to merge 1 commit into from
Closed

Bump rack version in Gemfile to ~> 2.0 #278

wants to merge 1 commit into from

Conversation

tiabas
Copy link

@tiabas tiabas commented Nov 30, 2016

The version of Rack in the Gemfile is ~> 1.2 whereas in the gemspec it is [>=1.0, <3]. For projects relying on this gem but requiring rack ~> 2.0 bundler fails because it builds agains thte definition in the Gemfile. I have bumped the version so that projects requiring a higher version of rack can still build their bundles

@tiabas tiabas changed the title Bumped rack version in Gemfile Bump rack version in Gemfile to ~> 2.0 Nov 30, 2016
@tiabas
Copy link
Author

tiabas commented Nov 30, 2016

May I get some input on how best I can make this change. I'm trying to update the gem version so that I can get Omniauth gem to build on Rails 5.0.0.1. The minimum rack version in Rails 5 is 2.0

@josephpage
Copy link
Member

Thanks @tiabas
Probably already fixed in #326.

@josephpage josephpage closed this Jan 12, 2018
@pboling
Copy link
Member

pboling commented Jan 12, 2018

@josephpage I believe #326 kept rack at 1.2.0 in the Gemfile. We still need to address this, though I'm not sure of the best way to do that, or if this PR is exactly what we want. There may be other considerations in a major version bump of rack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants