Update Faraday dependency to < 0.14 #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for this. Looks like failures are related to Rubocop, which seems odd since you didn't change any code. Is that a known issue? |
Merged
|
+1 for this. Anything I can do to help get it done? |
|
@zacharywelch can you run @ismasan you can redo this PR change (and resubmit) with Rubocop fixes so the build goes green! |
Closed
zacharywelch
force-pushed
the
zw/update-faraday-0.13.1
branch
3 times, most recently
from
1011d56
to
ba65f82
Compare
|
@zacharywelch thanks for the heads up on that PR. Merged it. We are now good here. I'm a new owner/maintainer, just getting familiar with the state of the project, trying to revive it. (All help is appreciated!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #315
Latest version of faraday is 0.13.1