Fix client fetch_token throwing NoMethodError when raise_errors is set to false

[joaolrpaulo]

The problem occurs when the identifier service is unreachable and we are passing the :raise_errors option set to false.

The fetch_token method throws NoMethodError while trying to perform the following code:

response.parsed.merge(access_token_opts)

This happens because the response.parsed is nil.

[joaolrpaulo]

Related to opened issue: #459

[coveralls]

Pull Request Test Coverage Report for Build 937

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at ?%

---

Totals
Change from base Build 847:	0.0%
Covered Lines:
Relevant Lines:	0

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 848

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at ?%

---

Totals
Change from base Build 847:	0.0%
Covered Lines:
Relevant Lines:	0

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 848

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at ?%

---

Totals
Change from base Build 847:	0.0%
Covered Lines:
Relevant Lines:	0

---

💛 - Coveralls

[pboling]

This is excellent. If you have time to think about a solution, please do! Otherwise one of the maintainers may look at this eventually. We're all short on time, and long on commitments, so this project is primarily running on community effort.

[joaolrpaulo]

Hello @pboling, I was really short on time to contribute to this PR. But here you go.

My suggestion to this is to return nil when there is now way we can build the access token, which is the saying the same that !response_contains_token.

Cheers mate!

[pboling]

Thanks @joaolrpaulo !!

[joaolrpaulo]

Hello @pboling, is there a possibility to add this to a new patch release in order for we to use it ?

[pboling]

@joaolrpaulo it would have to be backported to the 1-4-stable branch, as a second PR.

[joaolrpaulo]

I will do it in the next few days 🙏